Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Document fold operations for functions #302

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Document fold operations for functions #302

merged 2 commits into from
Oct 26, 2023

Conversation

Licenser
Copy link
Member

add fold operators for tremor-rs/tremor-runtime#2349

@netlify
Copy link

netlify bot commented Sep 25, 2023

Deploy Preview for tremor-www ready!

Name Link
🔨 Latest commit 3464803
🔍 Latest deploy log https://app.netlify.com/sites/tremor-www/deploys/653a32be1469a60008a47c67
😎 Deploy Preview https://deploy-preview-302--tremor-www.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

mfelsche
mfelsche previously approved these changes Sep 26, 2023
Copy link
Member

@mfelsche mfelsche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seeing this table, I am a bit sad, that fold isnt truly generic yet, e.g. supporting binary or and and might be a niche case, but why not support it?

Other than that, this looks superb.

@Licenser
Copy link
Member Author

Only reason is that it's a niche case and I wasn't sure if we should support it :D

@Licenser
Copy link
Member Author

It is now updated 🚀

Copy link
Member

@darach darach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Signed-off-by: Heinz N. Gies <[email protected]>
@Licenser Licenser merged commit 5aca580 into main Oct 26, 2023
5 checks passed
@Licenser Licenser deleted the fold branch October 26, 2023 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants