Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pandas 2 #138

Merged
merged 8 commits into from
Sep 17, 2024
Merged

Support pandas 2 #138

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
8a37db4
Test compatibility with pandas 2.2.2
tung-vu-td Sep 10, 2024
40a7aa8
Run CI on support-3.12 branch
tung-vu-td Sep 10, 2024
2ace066
Exclude python 3.8 - pandas 2.2.2 pair
tung-vu-td Sep 10, 2024
37fed59
Add test for pandas 2.0.3 & 2.1.4
tung-vu-td Sep 16, 2024
21a6fe4
Test on branch support-pandas-2
tung-vu-td Sep 16, 2024
7cf539f
.
tung-vu-td Sep 16, 2024
cad4317
Test only major versions of pandas
tung-vu-td Sep 17, 2024
0b47b40
Update suggested version for urllib3
tung-vu-td Sep 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 8 additions & 2 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@ name: Build

on:
push:
branches: [ master ]
branches: [ master, support-3.12 ]
pull_request:
branches: [ master ]

Expand All @@ -15,12 +15,18 @@ jobs:
matrix:
os: [ubuntu-latest, windows-latest]
python-version: ["3.8", "3.9", "3.10", "3.11"]
pandas-version: ["1.3.5", "1.4.4", "1.5.3"]
pandas-version: ["1.3.5", "1.4.4", "1.5.3", "2.0.3", "2.1.4", "2.2.2"]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think testing over two versions would be enough, i.e., 1.5.3 and 2.2.2. Is there any specific reason to test for 1.3.5, 1.4.4, 2.0.3, and 2.1.4?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No specific reason. I'm just following current convention (1.3, 1.4, 1.5)

If you think it's uneccessary, I'll test major versions only. I think testing minor version has limited benefit as well (unless there is some bug in one of pandas versions). Testing only 2 versions will drastically improve test time (now close to 1 hour 😬 )

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, then let's test 2 major versions only.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated in cad4317

exclude:
- python-version: "3.10"
pandas-version: "1.3.5"
- python-version: "3.10"
pandas-version: "1.4.4"
- python-version: "3.8"
pandas-version: "2.0.3"
- python-version: "3.8"
pandas-version: "2.1.4"
- python-version: "3.8"
pandas-version: "2.2.2"


steps:
Expand Down
5 changes: 4 additions & 1 deletion noxfile.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,9 +17,12 @@ def lint(session):
[
(python, pandas)
for python in ("3.8", "3.9", "3.10", "3.11")
for pandas in ("1.3.5", "1.4.4", "1.5.3")
for pandas in ("1.3.5", "1.4.4", "1.5.3", "2.0.3", "2.1.4", "2.2.2")
if (python, pandas) != ("3.10", "1.3.5")
if (python, pandas) != ("3.10", "1.4.4")
if (python, pandas) != ("3.8", "2.0.3")
if (python, pandas) != ("3.8", "2.1.4")
if (python, pandas) != ("3.8", "2.2.2")
],
)
def tests(session, python, pandas):
Expand Down
2 changes: 1 addition & 1 deletion setup.cfg
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ python_requires = >=3.7,<3.12
install_requires =
urllib3~=1.26,>=1.21.1
tung-vu-td marked this conversation as resolved.
Show resolved Hide resolved
presto-python-client>=0.6.0
pandas>=1.3,<1.6
pandas>=1.3
td-client>=1.1.0
pytz>=2018.5
numpy<1.24
Expand Down