Cap tempfile number up to 200 #137
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
To avoid OSError when writing large files, the chunk number is capped at 200. This number comes from the maximum number of open files allowed by macOS.
chezou
force-pushed
the
chunk-size-cap
branch
from
5a021ae
to
f597395
Compare
chezou
changed the title
chezou
changed the title
chezou
force-pushed
the
chunk-size-cap
branch
3 times, most recently
from
08d6a36
to
f597395
Compare
chezou
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current BulkImport writer uses tempfile, and it opens files at once before parallel bulk importing. In some cases, it creates too many opening files and OSError depending on the chunk size.
To avoid OSError when writing large files, the chunk number is to be capped at most 200.