added condition to service property #150
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
td-agent v4 does not ship /etc/init.d/td-agent file for distros that use systemd (ubuntu focal, for example maybe also others). This makes chef-client fail to run restart of service, since that was hardcoded to use init.d script. This adds a condistion to only set that property if the file actually esists. If it doesn't exist, then chefs service-mechanism will default to using whatever is available (systemd in this case) and the chef-run succeeds to restart the service properly.
|
The "offending" line in recipes/configure.rb: https://github.com/treasure-data/chef-td-agent/blob/master/recipes/configure.rb#L45 closes #151 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
td-agent v4 does not ship /etc/init.d/td-agent file for distros that use
systemd (ubuntu focal, for example maybe also others). This makes
chef-client fail to run restart of service, since that was hardcoded to
use init.d script.
This adds a condistion to only set that property if the file actually
esists. If it doesn't exist, then chefs service-mechanism will default
to using whatever is available (systemd in this case) and the chef-run
succeeds to restart the service properly.