Merge pull request #40 from trayio/taniya-amidon/CSP-3693/utils-bug-f…

…ix-for-deleteemptyobjects-method

[CSP-3693] utils bug fix for deletEemptyobjects method

lib/removeEmptyObjects.js

@@ -48,7 +48,7 @@ const removeEmptyObjects = collection => {
 		// this will remove empty objects if the child element was populated on first iteration and is now empty.
 		return _.isEmpty(clean_object) ? null : clean_object;
 	}
-	return undefined;
+	return collection;
 };
 
 module.exports = removeEmptyObjects;

package.json

@@ -1,50 +1,50 @@
 {
-	"name": "@trayio/connector-utils",
-	"version": "0.3.0",
-	"description": "Common utility functions used in connectors.",
-	"main": "lib/index.js",
-	"scripts": {
-		"coverage": "npm run test -- --coverage",
-		"lint": "./node_modules/.bin/eslint . --fix",
-		"test": "jest tests",
-		"test:watch": "jest tests --watch --notify"
-	},
-	"repository": {
-		"type": "git",
-		"url": "git+https://github.com/trayio/falafel-utils.git"
-	},
-	"keywords": [
-		"falafel",
-		"connectors"
-	],
-	"files": [
-		"index.js",
-		"/lib"
-	],
-	"author": "tray.io",
-	"license": "ISC",
-	"bugs": {
-		"url": "https://github.com/trayio/connector-utils/issues"
-	},
-	"homepage": "https://github.com/trayio/connector-utils#readme",
-	"devDependencies": {
-		"@trayio/connector-test-runner": "^0.5.0",
-		"@trayio/falafel": "^1.26.0",
-		"eslint": "^6.8.0",
-		"eslint-config-airbnb-base": "^14.1.0",
-		"eslint-config-prettier": "^6.10.0",
-		"eslint-plugin-import": "^2.20.1",
-		"eslint-plugin-jest": "^23.8.2",
-		"eslint-plugin-jsx-a11y": "^6.2.3",
-		"eslint-plugin-prettier": "^3.1.2",
-		"eslint-plugin-promise": "^4.2.1",
-		"jest": "^25.1.0",
-		"jest-json-schema": "^2.1.0",
-		"jsdoc-to-markdown": "^5.0.3",
-		"prettier": "^1.19.1"
-	},
-	"dependencies": {
-		"lodash": "~4.17.15",
-		"mustache": "^4.0.1"
-	}
-}
+    "name": "@trayio/connector-utils",
+    "version": "0.3.1",
+    "description": "Common utility functions used in connectors.",
+    "main": "lib/index.js",
+    "scripts": {
+        "coverage": "npm run test -- --coverage",
+        "lint": "./node_modules/.bin/eslint . --fix",
+        "test": "jest tests",
+        "test:watch": "jest tests --watch --notify"
+    },
+    "repository": {
+        "type": "git",
+        "url": "git+https://github.com/trayio/falafel-utils.git"
+    },
+    "keywords": [
+        "falafel",
+        "connectors"
+    ],
+    "files": [
+        "index.js",
+        "/lib"
+    ],
+    "author": "tray.io",
+    "license": "ISC",
+    "bugs": {
+        "url": "https://github.com/trayio/connector-utils/issues"
+    },
+    "homepage": "https://github.com/trayio/connector-utils#readme",
+    "devDependencies": {
+        "@trayio/connector-test-runner": "^0.5.0",
+        "@trayio/falafel": "^1.26.0",
+        "eslint": "^6.8.0",
+        "eslint-config-airbnb-base": "^14.1.0",
+        "eslint-config-prettier": "^6.10.0",
+        "eslint-plugin-import": "^2.20.1",
+        "eslint-plugin-jest": "^23.8.2",
+        "eslint-plugin-jsx-a11y": "^6.2.3",
+        "eslint-plugin-prettier": "^3.1.2",
+        "eslint-plugin-promise": "^4.2.1",
+        "jest": "^25.1.0",
+        "jest-json-schema": "^2.1.0",
+        "jsdoc-to-markdown": "^5.0.3",
+        "prettier": "^1.19.1"
+    },
+    "dependencies": {
+        "lodash": "~4.17.15",
+        "mustache": "^4.0.1"
+    }
+}

tests/methods/removeEmptyObjects.test.js

@@ -8,10 +8,12 @@ describe('Helper should remove all empty objects from the payload', () => {
 				key2: 'someval',
 				key3: {},
 				key4: 'other value',
+				key5: ['foo', 'bar'],
 			}),
 		).toEqual({
 			key2: 'someval',
 			key4: 'other value',
+			key5: ['foo', 'bar'],
 		});
 	});
 
@@ -140,4 +142,16 @@ describe('Helper should remove all empty objects from the payload', () => {
 			},
 		});
 	});
+	test('It does not remove string type values from arrays', () => {
+		expect(
+			removeEmptyObjects({
+				key: ['foo', 'bar'],
+				key1: [],
+				key2: [{ foo: 'bar' }],
+			}),
+		).toEqual({
+			key: ['foo', 'bar'],
+			key2: [{ foo: 'bar' }],
+		});
+	});
 });