[CENNSO-2440] fix: force tcp app notification #56
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add TCP_CONN_APP_DONT_NOTIF flag to fix optimizationcase when FIN was received in SYN_RCVD state and caused unexpected notification during scheduled removal when trying to avoid notifications for session which was not notified to application. Add TCP_CONN_FORCE_NOTIFY flag to disable such optimization and always notify session. This is needed for UPG, since it "owns" state of session and should be always notified about changes.
mogaika
requested review from
demo-exe,
td2501 and
dkalashnik
as code owners
td2501
approved these changes
Nov 26, 2024
demo-exe
approved these changes
Nov 27, 2024
|
lgtm |
mogaika
added a commit
that referenced
this pull request
Nov 27, 2024
Add TCP_CONN_APP_DONT_NOTIF flag to fix optimizationcase when FIN was received in SYN_RCVD state and caused unexpected notification during scheduled removal when trying to avoid notifications for session which was not notified to application. Add TCP_CONN_FORCE_NOTIFY flag to disable such optimization and always notify session. This is needed for UPG, since it "owns" state of session and should be always notified about changes.
mogaika
added a commit
that referenced
this pull request
Nov 27, 2024
Add TCP_CONN_APP_DONT_NOTIF flag to fix optimizationcase when FIN was received in SYN_RCVD state and caused unexpected notification during scheduled removal when trying to avoid notifications for session which was not notified to application. Add TCP_CONN_FORCE_NOTIFY flag to disable such optimization and always notify session. This is needed for UPG, since it "owns" state of session and should be always notified about changes.
mogaika
added a commit
that referenced
this pull request
Nov 27, 2024
Add TCP_CONN_APP_DONT_NOTIF flag to fix optimizationcase when FIN was received in SYN_RCVD state and caused unexpected notification during scheduled removal when trying to avoid notifications for session which was not notified to application. Add TCP_CONN_FORCE_NOTIFY flag to disable such optimization and always notify session. This is needed for UPG, since it "owns" state of session and should be always notified about changes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add TCP_CONN_APP_DONT_NOTIF flag to fix optimization case when FIN was received in SYN_RCVD state and caused unexpected notification during scheduled removal when trying to avoid notifications for session which was not notified to application.
Add TCP_CONN_FORCE_NOTIFY flag to disable such optimization and always notify session. This is needed for UPG, since it "owns" state of session and should be always notified about changes.