Conformance binary for AWS #316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
AlCutter
approved these changes
Nov 18, 2024
phbnf
force-pushed
the
conformanceaws
branch
from
635c61f
to
8b3bac6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Towards #24 and #312
Verified that
docker build -f ./cmd/conformance/aws/Dockerfile .works.This PR uses password based authentication for now, which is good enough to start with. I've tested IAM based authentication, which works. Let's get all the terraform in with passwords, and then we can eventually move to IAM.
While we're there, get rid for verifiers in
signerFromFlagssince we don't use them anymore.