Calculate merged checkpoints on write, not read #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlCutter
approved these changes
Nov 2, 2023
This makes the read path much cheaper, and fixes an issue (demonstrated in the tests) that previously seen checkpoint.N could previously go missing. One functional change is that asking for checkpoint.N will now return precisely N signatures instead of at least N signatures. The DB deployment is made a fraction more complicated by the introduction of another table, but its worthwhile doing this now while we have no production distributors.
mhutchinson
force-pushed
the
rememberN
branch
from
b76ea13 to
ad50574
Compare
AlCutter
approved these changes
Nov 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes the read path much cheaper, and fixes an issue (demonstrated in the tests) that previously seen checkpoint.N could previously go missing. One functional change is that asking for checkpoint.N will now return precisely N signatures instead of at least N signatures.
The DB deployment is made a fraction more complicated by the introduction of another table, but its worthwhile doing this now while we have no production distributors.