Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

52 improve code quality bucket related #82

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

52 improve code quality bucket related #82

wants to merge 5 commits into from

Conversation

elroykanye
Copy link
Contributor

@elroykanye elroykanye commented May 19, 2022 •
edited
Loading

Contributor Checklist

Fixes #52

  • Did you add comments for every public function/method?
  • Did you add at least one test demonstrating the PR?
  • Did you specify the type of improvement?
  • Did you state the API impact?
  • Did you specify the code generation impact?
  • Did you request a desired merge strategy?
  • Did you add text to be included in the Release Notes for this change?

Type of Improvement

  • bug fix
  • documentation
  • code refactoring
  • code cleanup
  • new feature/API

API Impact

Backend Code Generation Impact

Desired Merge Strategy

Release Notes

Reviewer Checklist (only modified by reviewer)

  • Did you add the appropriate labels?
  • Did you mark the proper milestone (Bug fix: 3.4.x, [small] API extension: 3.5.x, API modification or big change: 3.6.0)?
  • Did you review?
  • Did you check whether all relevant Contributor checkboxes have been checked?

@github-actions
Copy link

This pull request has not had activity for a long time. Consider closing or drafting it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elroyvince elroyvince Awaiting requested review from elroyvince elroyvince is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
application no-pr-activity
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

improve code quality - bucket related
1 participant
@elroykanye