Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Shrinking padding on mobile to show data better #971

Merged
merged 3 commits into from
Apr 13, 2024
Merged

Shrinking padding on mobile to show data better #971

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
48348ff
Shrinking padding on mobile to show data better
devinmatte Apr 6, 2024
8fb3286
Merge branch 'main' into shrink-padding-mobile
devinmatte Apr 8, 2024
ba6a440
Merge branch 'main' into shrink-padding-mobile
nathan-weinberg Apr 13, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion common/components/widgets/WidgetDiv.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@ interface WidgetDivProps {

export const WidgetDiv: React.FC<WidgetDivProps> = ({ children, className }) => {
return (
<div className={classNames(className, 'h-full rounded-lg bg-white p-4 shadow-dataBox')}>
<div className={classNames(className, 'h-full rounded-lg bg-white p-3 shadow-dataBox sm:p-4')}>
{children}
</div>
);
Expand Down
4 changes: 2 additions & 2 deletions common/layouts/DashboardLayout.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,8 +23,8 @@ export const DashboardLayout: React.FC<DashboardLayoutProps> = ({ children }) =>
<div className="flex flex-1 flex-col pb-24 md:pb-0 md:pl-64">
<main className="flex-1">
{isMobile ? <MobileHeader /> : <DesktopHeader />}
<div className="py-2 md:py-6">
<div className="h-full px-4 sm:px-6 md:px-8">
<div className="py-2 md:py-4">
<div className="h-full px-2 sm:px-4 md:px-6">
<WidgetPage>{children}</WidgetPage>
</div>
</div>
Expand Down
2 changes: 1 addition & 1 deletion modules/commute/alerts/Alerts.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ export const Alerts: React.FC<AlertsProps> = ({ title, alerts }) => {
} = useDelimitatedRoute();

const divStyle = classNames(
'flex flex-col rounded-md py-4 text-white shadow-dataBox w-full gap-y-2 md:max-h-[309px] md:overflow-y-auto',
'flex flex-col rounded-md py-3 sm:py-4 text-white shadow-dataBox w-full gap-y-2 md:max-h-[309px] md:overflow-y-auto',
lineColorBackground[line ?? 'DEFAULT']
);

Expand Down
2 changes: 1 addition & 1 deletion modules/slowzones/SystemSlowZonesDetails.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ export function SystemSlowZonesDetails({ showTitle = false }: SystemSlowZonesDet
})}
/>
</WidgetDiv>
<div className="h-full rounded-lg bg-white p-4 shadow-dataBox">
<div className="h-full rounded-lg bg-white p-3 shadow-dataBox sm:p-4">
<div className="flex flex-col p-4 sm:p-0 lg:flex-row">
<WidgetTitle title={`${DirectionObject[direction]} segments`} />
<div className="lg:ml-2">
Expand Down
Loading