CI improvements #307
Merged
CI improvements #307
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Almenon
reviewed
Jan 31, 2024
Almenon
reviewed
Jan 31, 2024
|
jinx ~ #301. great minds think alike I guess 😅 . |
|
@Almenon I admit I didn't thoroughly inspect other PRs, though I see you closed yours in the meantime 😄 |
Almenon
reviewed
Feb 1, 2024
Almenon
reviewed
Feb 1, 2024
Almenon
reviewed
Feb 1, 2024
Almenon
reviewed
Feb 1, 2024
|
Almost there 😅 https://i.imgur.com/9esFVWe.png |
Almenon
approved these changes
Feb 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm glad to see this project being revived!
I've been maintaining a fork used internally by our company and here are some CI fixes and improvements that might benefit the upstream project.
The most backward-incompatible change is probably around the build workflows, removing goxc which is no longer maintained, and changing the build artifact names and checksums (easier to remote copy the binaries directly instead of having to unzip files). I'm happy to discuss further some of these changes of course.