-
Notifications
You must be signed in to change notification settings - Fork 762
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(Traefik Proxy): allowEmptyServices not disabled when set to false #1256
fix(Traefik Proxy): allowEmptyServices not disabled when set to false #1256
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR. Could you add the corresponding unit tests ?
002b0cd
to
6dcc5fd
Compare
@darkweaver87 added |
05b0c54
to
1a480bd
Compare
@MaximilianMeister I updated this PR title following conventional commit. Feel free to update my edit if I missed something. |
thanks, i'll update the commit messages accordingly |
1a480bd
to
e678259
Compare
There is a tiny indentation space missed. Otherwise, LGTM. Thanks 👍 |
e678259
to
0bea0a1
Compare
thanks, i rebased with your suggestion, please have another look |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Good job 👍 thanks
If we don't explicitly set the cmdline flags to false, they will default to true
Co-authored-by: Michel Loiseleur <[email protected]>
0bea0a1
to
34f01e8
Compare
What does this PR do?
Explicitly disallow empty services when values are set this way:
Motivation
The bug is if we don't explicitly set the cmdline flags to false, they will always default to true:
More
make test
and all the tests passed