Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Traefik): support for entrypoint option on allowACMEByPass #1246

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

mback2k
Copy link
Contributor

@mback2k mback2k commented Nov 1, 2024

What does this PR do?

Allow allowACMEByPass to be used on entrypoints other than name.

Motivation

Fixes #1245

More

  • Yes, I updated the tests accordingly
  • Yes, I updated the schema accordingly
  • Yes, I ran make test and all the tests passed

Copy link
Contributor

@darkweaver87 darkweaver87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mloiseleur mloiseleur changed the title Fix support for entrypoint option allowACMEByPass fix(Traefik): support for entrypoint option on allowACMEByPass Nov 4, 2024
@mloiseleur
Copy link
Contributor

Thanks @mback2k . It's clearly better with this fix !

@traefiker traefiker merged commit 18fcb8c into traefik:master Nov 4, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Entrypoint option allowACMEBypass is not working
4 participants