Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Traefik Hub): 🍻 add E2E tests on RBACs change #1151

Merged
merged 1 commit into from
Jul 30, 2024
Merged

feat(Traefik Hub): 🍻 add E2E tests on RBACs change #1151

merged 1 commit into from
Jul 30, 2024

Conversation

darkweaver87
Copy link
Contributor

@darkweaver87 darkweaver87 commented Jul 30, 2024 •
edited
Loading

What does this PR do?

This PR adds E2E tests when touching to RBACS.

Motivation

We recently had multiple RBACs issues with Traefik Hub. This test should prevent from merging breaking PRs.

More

  • Yes, I updated the tests accordingly
  • Yes, I ran make test and all the tests passed

@darkweaver87 darkweaver87 added the kind/enhancement New feature or request label Jul 30, 2024
@darkweaver87 darkweaver87 mentioned this pull request Jul 30, 2024
Closed
2 tasks
@darkweaver87 darkweaver87 force-pushed the feat/tests branch 3 times, most recently from 0c7480b to a140913 Compare July 30, 2024 07:44
@darkweaver87
Copy link
Contributor Author

Working per test: https://github.com/traefik/traefik-helm-chart/actions/runs/10158246699

@traefiker traefiker merged commit dd3bee0 into master Jul 30, 2024
1 check passed
@traefiker traefiker deleted the feat/tests branch July 30, 2024 07:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmatur mmatur mmatur approved these changes

Assignees
No one assigned
Labels
kind/enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@darkweaver87 @mmatur @traefiker