Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skip adding fluent actions menu if it already exists #908

Merged
merged 1 commit into from
Nov 19, 2024

Conversation

xini
Copy link
Contributor

@xini xini commented Nov 19, 2024

Description

This fixes #888, where in certain situations (e.g. ModelAdmin) the fluent actions menu is added twice, resulting in an error when the form is submitted.

Manual testing steps

see #888

Issues

Pull request checklist

  • The target branch is correct
  • All commits are relevant to the purpose of the PR (e.g. no debug statements, unrelated refactoring, or arbitrary linting)
    • Small amounts of additional linting are usually okay, but if it makes it hard to concentrate on the relevant changes, ask for the unrelated changes to be reverted, and submitted as a separate PR.
  • The commit messages follow our commit message guidelines
  • The PR follows our contribution guidelines
  • Code changes follow our coding conventions
  • This change is covered with tests (or tests aren't necessary for this change)
  • Any relevant User Help/Developer documentation is updated; for impactful changes, information is added to the changelog for the intended release
  • CI is green

@tractorcow tractorcow merged commit fb2c518 into tractorcow-farm:7 Nov 19, 2024
9 checks passed
@xini
Copy link
Contributor Author

xini commented Dec 2, 2024

@tractorcow thanks for the merge. Can this be released as a patch? Cheers

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Double calls of updateFluentActions lead to RuntimeException
2 participants