bugfix

images were overwritten by wp_generate_attachment_metadata
tpow · Apr 19, 2016 · 69fdc74 · 69fdc74
1 parent 611029c
commit 69fdc74
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 4 deletions.
diff --git a/lib/ManualImageCrop.php b/lib/ManualImageCrop.php
@@ -174,7 +174,11 @@ private function filterPostData() {
 	 * Callback function for plugin: amazon-s3-and-cloudfront
 	 */
 	function get_attached_file_copy_back_to_local( $copy_back_to_local, $file, $attachment_id ) {
-		return true; // we want the image on the server
+		if ( !file_exists($file)) {
+			return true; // we want the image on the server
+		} else {
+			return false;
+		}
 	}
 
 	/**

diff --git a/lib/ManualImageCropEditorWindow.php b/lib/ManualImageCropEditorWindow.php
@@ -97,11 +97,11 @@ public function renderWindow() {
 			add_filter( 'as3cf_get_attached_file_copy_back_to_local', 'ManualImageCrop::get_attached_file_copy_back_to_local', 10, 3 );
 
 			// function get_attached_file is called to trigger the hook above
-			$metaData = wp_generate_attachment_metadata($postId,get_attached_file($postId));
-		} else {
-			$metaData = wp_get_attachment_metadata($postId);
+			get_attached_file($postId);
 		}
 
+		$metaData = wp_get_attachment_metadata($postId);
+
 		if (!$metaData) {
 			echo json_encode (array('status' => 'error', 'message' => 'could not get metadata for attachement(' . $postId . ') try reuploading the file' ) );
 			exit;