Fix use of PCR16 #2879
Open
Fix use of PCR16 #2879
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Andreas Fuchs <[email protected]>
The test harness for integration tests now check before and after every integration test invocation if PCR16 is empty to begin but also after the test. Signed-off-by: Andreas Fuchs <[email protected]>
AndreasFuchsTPM
force-pushed
the
test_pcr16
branch
from
37c2c1e
to
6a78aa7
Compare
joholl
approved these changes
Aug 2, 2024
| } | ||
|
|
||
| if (pcr_values.count != 1) { | ||
| LOG_ERROR("TPM2_PCR_Read for PCR 16 in SHA256 did not return a value"); |
There was a problem hiding this comment.
Did you forget a return EXIT_ERROR; here?
| TSS2_RC rc; | ||
| TPML_DIGEST pcr_values = { 0 }; | ||
| TPML_PCR_SELECTION pcr_selection = { .count=1, .pcrSelections = { { .hash = TPM2_ALG_SHA256, .sizeofSelect = 3, .pcrSelect = { 0 } } } }; | ||
| pcr_selection.pcrSelections[0].pcrSelect[(16 / 8)] = 1 << (16 % 8); |
There was a problem hiding this comment.
Do we not have a macro for this?
| @@ -44,7 +46,7 @@ struct { | |||
| }; | |||
|
|
|||
| struct tpm_state { | |||
| TPMS_CAPABILITY_DATA capabilities[7]; | |||
| TPMS_CAPABILITY_DATA capabilities[sizeof(capabilities_to_dump) / sizeof(capabilities_to_dump[0])]; | |||
There was a problem hiding this comment.
ARRAY_LEN() is defined in src/util/aux_util.h
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2877