test_esapi: use tr_from_tpmpublic with NV index #311
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In order to read a NV index from a "TPM index", the function `tr_from_tpmpublic` needs to be used first. Add such a use-case in the test suite. This was discussed in tpm2-software#298. Signed-off-by: Nicolas Iooss <[email protected]>
Codecov Report
@@ Coverage Diff @@
## master #311 +/- ##
=======================================
Coverage 93.54% 93.54%
=======================================
Files 15 15
Lines 4665 4665
Branches 591 591
=======================================
Hits 4364 4364
Misses 219 219
Partials 82 82 Continue to review full report at Codecov.
|
|
FYI, I'm currently working on some examples, one which covers this (and our discussion in the issue), so I'm not really sure this is needed as it doesn't increase the coverage. |
|
Seems to be addressed in: 8fd7d70 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to read a NV index from a "TPM index", the function
tr_from_tpmpublicneeds to be used first. Add such a use-case in the test suite.This was discussed in #298.