Fix for the "-Wterminate" warnings of GCC 6 #22
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just another small thing that came up when I started using cppcodec in my C++11 project.
There were a few methods which were defined with the noexcept-specifier but included a throw-statement. In C++11, when throwing an exception inside a noexcept-method, std::terminate() gets called instead of the usual exception handling. Usually this isn't the wanted behavior, which is why GCC 6 now spits out a warning message when doing that.
I resolved this by removing the noexcept-specifier from these methods. Since they were meant to get inlined and weren't introducing variables on the stack, this shouldn't affect performance in a negative way.