Update unix.py #324
Closed
Update unix.py #324
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixed "_get_user_dirs_folder" function at unix.py file to expand both "$HOME" and "${HOME}" variables.
gaborbernat
requested changes
Nov 9, 2024
Sorry I don't know how to write a test for that simple change. I have never use neither Mock nor pytest just doctest. Moreover I think that the change avoid a possible error due to the use of brackets in bash variables like $HOME. Regards. |
|
I can't accept the change without tests, no matter how simple. Regards. |
|
Closing as seems it's stalled. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed
_get_user_dirs_folderfunction atunix.pyfile to expand both$HOMEand${HOME}variables.