Add base trait for improved driver abstraction #45
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
September 23, 2016 22:59
… support. By default, Slick code generator generates trait named `Table` which have abstract val profile. Importing a JdbcProfile inside this Table trait does not seem good. So we need this trait.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm currently using Slick Code Generator
which by default generates a trait with a abstract member of type JdbcProfile.
I think if we have a trait for GenericJodaSupport it would be better.
Also, we can support cake pattern, too.
This PR is a bit related with #36 #37
For backward compatibility, I just added new traits without changing any existing interfaces.