Ensure config.php is compatible with our supported PHP versions #299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markmetcalfe
commented
Nov 24, 2024
| 'ngrok-free.app', | ||
| 'ngrok.app', | ||
| ]; | ||
| $ngrok_urls = array('ngrok-free.app', 'ngrok.app'); |
There was a problem hiding this comment.
Note: I removed the .io URL as ngrok no longer uses .io
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our example config.php isn't compatible with PHP 5.3, so when someone tries to run a (very) old Totara site, they'll get an error since PHP 5.3 doesn't support the square bracket array syntax. This PR changes the config.php to use the
array()notation, and adds a CI check to ensure that any future changes to config.php are compatible with both PHP 5.3 and PHP 8