fix(react-router-dom): remove the misplaced character } (#64)

* fix: remove misspell * refactor: define the name of searchParams as a variable
toss · Sep 24, 2024 · caa33a8 · caa33a8
1 parent 4fb760d
commit caa33a8
Showing 1 changed file with 13 additions and 9 deletions.
diff --git a/packages/react-router-dom/src/index.ts b/packages/react-router-dom/src/index.ts
@@ -15,8 +15,12 @@ export const useFunnel = createUseFunnel<ReactRouterDomRouteOption>(({ id, initi
   const [searchParams, setSearchParams] = useSearchParams();
   const navigate = useNavigate();
 
-  const currentStep = searchParams.get(`${id}.step`);
-  const currentContext = location.state?.[`${id}.context`];
+  const stepName = `${id}.step`;
+  const contextName = `${id}.context`;
+  const historiesName = `${id}.histories`;
+
+  const currentStep = searchParams.get(stepName);
+  const currentContext = location.state?.[contextName];
   const currentState = useMemo(() => {
     return currentStep != null && currentContext != null
       ? ({
@@ -27,7 +31,7 @@ export const useFunnel = createUseFunnel<ReactRouterDomRouteOption>(({ id, initi
   }, [currentStep, currentContext, initialState]);
 
   const history: (typeof initialState)[] = useMemo(() => {
-    const histories = location.state?.[`${id}.histories`];
+    const histories = location.state?.[historiesName];
     if (Array.isArray(histories) && histories.length > 0) {
       return histories;
     } else {
@@ -44,15 +48,15 @@ export const useFunnel = createUseFunnel<ReactRouterDomRouteOption>(({ id, initi
       push(state, { preventScrollReset, unstable_flushSync, unstable_viewTransition } = {}) {
         setSearchParams(
           (prev) => {
-            prev.set(`${id}.step`, state.step);
+            prev.set(stepName, state.step);
             return prev;
           },
           {
             replace: false,
             state: {
               ...location.state,
-              [`${id}.context`]: state.context,
-              [`${id}.histories`]: [...(history ?? []), state],
+              [contextName]: state.context,
+              [historiesName]: [...(history ?? []), state],
             },
             preventScrollReset,
             unstable_flushSync,
@@ -63,15 +67,15 @@ export const useFunnel = createUseFunnel<ReactRouterDomRouteOption>(({ id, initi
       replace(state, { preventScrollReset, unstable_flushSync, unstable_viewTransition } = {}) {
         setSearchParams(
           (prev) => {
-            prev.set(`${id}.step`, state.step);
+            prev.set(stepName, state.step);
             return prev;
           },
           {
             replace: true,
             state: {
               ...location.state,
-              [`${id}.context`]: state.context,
-              [`${id}.histories}`]: [...(history ?? []).slice(0, currentIndex), state],
+              [contextName]: state.context,
+              [historiesName]: [...(history ?? []).slice(0, currentIndex), state],
             },
             preventScrollReset,
             unstable_flushSync,