Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(vitest, tsup): use built file #292

Merged
merged 2 commits into from
Nov 6, 2023
Merged

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Nov 4, 2023

fix #291

Overview

I used built file to remove unncessary compile time for @suspensive/tsup, @suspensive/vitest but with sustain their TypeScript autocomplete internally, externally for user of them

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

Copy link

changeset-bot bot commented Nov 4, 2023

⚠️ No Changeset found

Latest commit: 4e336d6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

vercel bot commented Nov 4, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2023 3:18am
visualization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 5, 2023 3:18am

@manudeli manudeli self-assigned this Nov 4, 2023
@github-actions github-actions bot added the eslint label Nov 4, 2023
@vercel vercel bot temporarily deployed to Preview – visualization November 4, 2023 07:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs November 4, 2023 07:13 Inactive
Copy link

codesandbox-ci bot commented Nov 4, 2023

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Copy link

codecov bot commented Nov 4, 2023

Codecov Report

Merging #292 (4e336d6) into main (98e4aa4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #292   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          806       806           
  Branches       136       136           
=========================================
  Hits           806       806           
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-query ∅ <ø> (∅)
@suspensive/react-await 100.00% <ø> (ø)

@manudeli manudeli marked this pull request as ready for review November 4, 2023 07:14
@vercel vercel bot temporarily deployed to Preview – docs November 5, 2023 03:17 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization November 5, 2023 03:18 Inactive
Copy link
Member

@minsoo-web minsoo-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many Thanks 👍

@manudeli manudeli merged commit 3fc3249 into main Nov 6, 2023
19 checks passed
@manudeli manudeli deleted the fix/tsup-vitest/no-build branch November 6, 2023 04:11
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #291 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I used built file to remove unncessary compile time for
@suspensive/tsup, @suspensive/vitest but with sustain their TypeScript
autocomplete internally, externally for user of them

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #291 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I used built file to remove unncessary compile time for
@suspensive/tsup, @suspensive/vitest but with sustain their TypeScript
autocomplete internally, externally for user of them

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #291 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I used built file to remove unncessary compile time for
@suspensive/tsup, @suspensive/vitest but with sustain their TypeScript
autocomplete internally, externally for user of them

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: remove build time of @suspensive/tsup, @suspensive/vitest
2 participants