Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(ms): add dev dependency #274

Merged
merged 2 commits into from
Oct 29, 2023
Merged

chore(ms): add dev dependency #274

merged 2 commits into from
Oct 29, 2023

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Oct 29, 2023 •
edited
Loading

fix #267

Overview

@minsoo-web suggest us to add ms in #264 (comment)
I added ms as dev dependency to test apis related with time

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@changeset-bot
Copy link

changeset-bot bot commented Oct 29, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 938b696

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel
Copy link

vercel bot commented Oct 29, 2023 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 9:42am
visualization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 29, 2023 9:42am

@manudeli manudeli self-assigned this Oct 29, 2023
@codecov
Copy link

codecov bot commented Oct 29, 2023 •
edited
Loading

Codecov Report

Merging #274 (938b696) into main (257b672) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #274   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           23        23           
  Lines          810       810           
  Branches       136       136           
=========================================
  Hits           810       810
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-query ∅ <ø> (∅)
@suspensive/react-await 100.00% <ø> (ø)

@manudeli manudeli marked this pull request as ready for review October 29, 2023 08:09
okinawaa
okinawaa approved these changes Oct 29, 2023
View reviewed changes
Copy link
Member

@okinawaa okinawaa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vercel vercel bot temporarily deployed to Preview – visualization October 29, 2023 09:42 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 29, 2023 09:42 Inactive
@manudeli manudeli merged commit 15a5531 into main Oct 29, 2023
13 checks passed
@manudeli manudeli deleted the chore/ms branch October 29, 2023 09:43
manudeli added a commit that referenced this pull request Aug 3, 2024
@manudeli
chore(ms): add dev dependency (#274)
151240f 
fix #267 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

@minsoo-web suggest us to add `ms` in
#264 (comment)
I added `ms` as dev dependency to test apis related with time

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
@manudeli
chore(ms): add dev dependency (#274)
23f8caa 
fix #267 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

@minsoo-web suggest us to add `ms` in
#264 (comment)
I added `ms` as dev dependency to test apis related with time

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
@manudeli
chore(ms): add dev dependency (#274)
3923505 
fix #267 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

@minsoo-web suggest us to add `ms` in
#264 (comment)
I added `ms` as dev dependency to test apis related with time

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@okinawaa okinawaa okinawaa approved these changes

@minsoo-web minsoo-web Awaiting requested review from minsoo-web

Assignees

@manudeli manudeli

Labels
dependencies @suspensive/react @suspensive/react-await
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature] ms package as root devDependency to test time
2 participants
@manudeli @okinawaa