Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): remove unnecessary @types/use-sync-external-store #257

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

manudeli
Copy link
Member

Overview

I remove unnecessary @types/use-sync-external-store

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@manudeli manudeli self-assigned this Oct 23, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 23, 2023

🦋 Changeset detected

Latest commit: 339edbf

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@suspensive/react Patch
@suspensive/react-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 23, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 5:09pm
visualization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 23, 2023 5:09pm

@manudeli manudeli marked this pull request as ready for review October 23, 2023 17:06
@vercel vercel bot temporarily deployed to Preview – docs October 23, 2023 17:08 Inactive
Copy link
Member

@minsoo-web minsoo-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@codecov
Copy link

codecov bot commented Oct 23, 2023

Codecov Report

Merging #257 (339edbf) into main (b5864d5) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #257   +/-   ##
=======================================
  Coverage   98.63%   98.63%           
=======================================
  Files          25       25           
  Lines         878      878           
  Branches      152      152           
=======================================
  Hits          866      866           
  Misses         12       12           
Components Coverage Δ
@suspensive/react 98.63% <ø> (ø)
@suspensive/react-query ∅ <ø> (∅)
@suspensive/react-await 95.12% <ø> (ø)

@vercel vercel bot temporarily deployed to Preview – visualization October 23, 2023 17:09 Inactive
@manudeli manudeli merged commit b908c02 into main Oct 23, 2023
13 checks passed
@manudeli manudeli deleted the react/fix/unncessary-types-use-sync-external-store branch October 23, 2023 17:12
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I remove unnecessary @types/use-sync-external-store

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I remove unnecessary @types/use-sync-external-store

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I remove unnecessary @types/use-sync-external-store

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants