Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(react): remove <Await/> #234

Merged
merged 16 commits into from
Oct 20, 2023
Merged

fix(react): remove <Await/> #234

merged 16 commits into from
Oct 20, 2023

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Oct 18, 2023

fix #203

Overview

I remove <Await/> to get below 2 things

  1. to get below in @suspensive/react
  1. to maintain <Await/>
  • add @suspensive/react-await

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

Co-authored-by: Eric Butler eric@codebutler.com

Sorry, something went wrong.

@changeset-bot
Copy link

changeset-bot bot commented Oct 18, 2023

🦋 Changeset detected

Latest commit: 0a7829b

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@suspensive/react-await Patch
@suspensive/react Patch
@suspensive/react-query Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 18, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 0:14am
visualization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 20, 2023 0:14am

@vercel vercel bot temporarily deployed to Preview – docs October 18, 2023 15:47 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization October 18, 2023 15:48 Inactive
@manudeli manudeli changed the title fix(react): remove await fix(react): remove <Await/> Oct 18, 2023
@vercel vercel bot temporarily deployed to Preview – docs October 18, 2023 15:50 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization October 18, 2023 15:51 Inactive
@codecov
Copy link

codecov bot commented Oct 18, 2023

Codecov Report

Merging #234 (0a7829b) into main (03992b5) will decrease coverage by 1.37%.
The diff coverage is 62.50%.

Impacted file tree graph

@@             Coverage Diff             @@
##              main     #234      +/-   ##
===========================================
- Coverage   100.00%   98.63%   -1.37%     
===========================================
  Files           22       25       +3     
  Lines          850      878      +28     
  Branches       150      152       +2     
===========================================
+ Hits           850      866      +16     
- Misses           0       12      +12     
Components Coverage Δ
@suspensive/react 98.63% <62.50%> (-1.37%) ⬇️
@suspensive/react-query ∅ <ø> (∅)

@vercel vercel bot temporarily deployed to Preview – visualization October 18, 2023 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 18, 2023 15:53 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 18, 2023 16:02 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization October 18, 2023 16:02 Inactive
@manudeli manudeli self-assigned this Oct 18, 2023
@vercel vercel bot temporarily deployed to Preview – docs October 18, 2023 16:11 Inactive
@manudeli manudeli marked this pull request as ready for review October 18, 2023 16:12
@vercel vercel bot temporarily deployed to Preview – docs October 19, 2023 11:19 Inactive
Comment on lines +1 to +25
import type { ReactNode } from 'react'

const suspendIsNeed = { current: true }
type SuspendProps = { during: number; toShow?: ReactNode }
export const Suspend = ({ during, toShow }: SuspendProps) => {
if (suspendIsNeed.current) {
throw new Promise((resolve) =>
setTimeout(() => {
suspendIsNeed.current = false
resolve('resolved')
}, during)
)
}
return <>{toShow}</>
}
Suspend.reset = () => {
suspendIsNeed.current = true
}

export const delay = (ms: number) => new Promise((resolve) => setTimeout(() => resolve('done'), ms))

export const TEXT = 'TEXT' as const
export const ERROR_MESSAGE = 'ERROR_MESSAGE' as const
export const FALLBACK = 'FALLBACK' as const
export const MS_100 = 100 as const
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@minsoo-web I think this will be good to make inner code as internal dev package. but not now

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay !!

@vercel
Copy link

vercel bot commented Oct 19, 2023

Deployment failed with the following error:

Resource is limited - try again in 22 minutes (more than 100, code: "api-deployments-free-per-day").

@vercel vercel bot temporarily deployed to Preview – visualization October 19, 2023 15:18 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 19, 2023 15:19 Inactive
Copy link
Member

@minsoo-web minsoo-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GooD!! 🔥🔥

@vercel vercel bot temporarily deployed to Preview – visualization October 20, 2023 11:48 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 20, 2023 11:49 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization October 20, 2023 12:09 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 20, 2023 12:10 Inactive
@vercel vercel bot temporarily deployed to Preview – visualization October 20, 2023 12:13 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 20, 2023 12:14 Inactive
@manudeli manudeli merged commit 7e01577 into main Oct 20, 2023
14 checks passed
@manudeli manudeli deleted the fix/remove-await branch October 20, 2023 12:18
manudeli added a commit that referenced this pull request Oct 24, 2023
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I add new dev package @suspensive/test-utils to gather test-utils
resolve
#234 (comment)

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #203

# Overview

I remove `<Await/>` to get below 2 things

1. to get below in @suspensive/react
- remove use-sync-external-store. it will fix #203 
- remove subpath. it will fix unnecessary node v10 resolution problem
- add lint:attw (check our status of are the types wrong in
[this](https://arethetypeswrong.github.io/?p=%40suspensive%2Freact%401.16.1))
  this validate many things

![image](https://github.com/suspensive/react/assets/61593290/643eaf4b-567d-4382-81f5-8aeca22aec37)



2. to maintain `<Await/>`
- add @suspensive/react-await

<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/slash/blob/main/.github/CONTRIBUTING.md)
2. I added documents and tests.

Co-authored-by: Eric Butler <eric@codebutler.com>

---------

Co-authored-by: Minsoo Kim <zlemzlem5656@naver.com>
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I add new dev package @suspensive/test-utils to gather test-utils
resolve
#234 (comment)

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #203

# Overview

I remove `<Await/>` to get below 2 things

1. to get below in @suspensive/react
- remove use-sync-external-store. it will fix #203 
- remove subpath. it will fix unnecessary node v10 resolution problem
- add lint:attw (check our status of are the types wrong in
[this](https://arethetypeswrong.github.io/?p=%40suspensive%2Freact%401.16.1))
  this validate many things

![image](https://github.com/suspensive/react/assets/61593290/643eaf4b-567d-4382-81f5-8aeca22aec37)



2. to maintain `<Await/>`
- add @suspensive/react-await

<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/slash/blob/main/.github/CONTRIBUTING.md)
2. I added documents and tests.


---------
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I add new dev package @suspensive/test-utils to gather test-utils
resolve
#234 (comment)

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this pull request Aug 3, 2024
fix #203

# Overview

I remove `<Await/>` to get below 2 things

1. to get below in @suspensive/react
- remove use-sync-external-store. it will fix #203 
- remove subpath. it will fix unnecessary node v10 resolution problem
- add lint:attw (check our status of are the types wrong in
[this](https://arethetypeswrong.github.io/?p=%40suspensive%2Freact%401.16.1))
  this validate many things

![image](https://github.com/suspensive/react/assets/61593290/643eaf4b-567d-4382-81f5-8aeca22aec37)



2. to maintain `<Await/>`
- add @suspensive/react-await

<!--
    A clear and concise description of what this pr is about.
 -->

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/toss/slash/blob/main/.github/CONTRIBUTING.md)
2. I added documents and tests.

Co-authored-by: Eric Butler <eric@codebutler.com>

---------

Co-authored-by: Minsoo Kim <zlemzlem5656@naver.com>
manudeli added a commit that referenced this pull request Aug 3, 2024
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

I add new dev package @suspensive/test-utils to gather test-utils
resolve
#234 (comment)

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants