advise(react/errorboundary): add & change example case #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
1 Ignored Deployment
|
1 task
Codecov Report
@@ Coverage Diff @@
## react/fix/useErrorBoundary-to-stable #221 +/- ##
======================================================================
Coverage 100.00% 100.00%
======================================================================
Files 21 21
Lines 842 842
Branches 149 149
======================================================================
Hits 842 842
|
manudeli
reviewed
Oct 15, 2023
There was a problem hiding this comment.
I left comment to edit some sentences as simple, commit suggestion please if you okay @minsoo-web
Co-authored-by: Jonghyeon Ko <[email protected]>
Co-authored-by: Jonghyeon Ko <[email protected]>
It is applied, thanks !! |
manudeli
approved these changes
Oct 15, 2023
|
Better examples thanks! |
manudeli
merged commit 90da45f
into
react/fix/useErrorBoundary-to-stable
11 checks passed
manudeli
added a commit
that referenced
this pull request
Oct 18, 2023
* feat(react): add useErrorBoundaryFallbackProps * chore: update * Create two-weeks-serve.md * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * docs: update * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * Update packages/react/src/ErrorBoundary.en.mdx Co-authored-by: 김석진 <[email protected]> * advise(react/errorboundary): add & change example case (#221) * docs(errorboundary): change & add example case for ErrorBoundary * docs(react/errorboundary): change & add example case to ErrorBoundary (en) * docs(react): suggestion to advise/useErrorBoundaryProps (#227) * Update ErrorBoundary.ko.mdx Co-authored-by: Jonghyeon Ko <[email protected]> * Update ErrorBoundary.en.mdx Co-authored-by: Jonghyeon Ko <[email protected]> --------- Co-authored-by: Jonghyeon Ko <[email protected]> --------- Co-authored-by: 김석진 <[email protected]> Co-authored-by: 김민수 <[email protected]>
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
* feat(react): add useErrorBoundaryFallbackProps * chore: update * Create two-weeks-serve.md * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * docs: update * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * Update packages/react/src/ErrorBoundary.en.mdx Co-authored-by: 김석진 <[email protected]> * advise(react/errorboundary): add & change example case (#221) * docs(errorboundary): change & add example case for ErrorBoundary * docs(react/errorboundary): change & add example case to ErrorBoundary (en) * docs(react): suggestion to advise/useErrorBoundaryProps (#227) * Update ErrorBoundary.ko.mdx Co-authored-by: Jonghyeon Ko <[email protected]> * Update ErrorBoundary.en.mdx Co-authored-by: Jonghyeon Ko <[email protected]> --------- Co-authored-by: Jonghyeon Ko <[email protected]> --------- Co-authored-by: 김석진 <[email protected]> Co-authored-by: 김민수 <[email protected]>
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
* feat(react): add useErrorBoundaryFallbackProps * chore: update * Create two-weeks-serve.md * Update packages/react/src/ErrorBoundary.ko.mdx * Update packages/react/src/ErrorBoundary.ko.mdx * Update packages/react/src/ErrorBoundary.ko.mdx * docs: update * Update packages/react/src/ErrorBoundary.ko.mdx * Update packages/react/src/ErrorBoundary.en.mdx * advise(react/errorboundary): add & change example case (#221) * docs(errorboundary): change & add example case for ErrorBoundary * docs(react/errorboundary): change & add example case to ErrorBoundary (en) * docs(react): suggestion to advise/useErrorBoundaryProps (#227) * Update ErrorBoundary.ko.mdx * Update ErrorBoundary.en.mdx --------- ---------
manudeli
added a commit
that referenced
this pull request
Aug 3, 2024
* feat(react): add useErrorBoundaryFallbackProps * chore: update * Create two-weeks-serve.md * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * docs: update * Update packages/react/src/ErrorBoundary.ko.mdx Co-authored-by: 김석진 <[email protected]> * Update packages/react/src/ErrorBoundary.en.mdx Co-authored-by: 김석진 <[email protected]> * advise(react/errorboundary): add & change example case (#221) * docs(errorboundary): change & add example case for ErrorBoundary * docs(react/errorboundary): change & add example case to ErrorBoundary (en) * docs(react): suggestion to advise/useErrorBoundaryProps (#227) * Update ErrorBoundary.ko.mdx Co-authored-by: Jonghyeon Ko <[email protected]> * Update ErrorBoundary.en.mdx Co-authored-by: Jonghyeon Ko <[email protected]> --------- Co-authored-by: Jonghyeon Ko <[email protected]> --------- Co-authored-by: 김석진 <[email protected]> Co-authored-by: 김민수 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
This PR is for clear example case for #216
PR Checklist