Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(eslint): add no-duplicates, consistent-type-imports #219

Merged
merged 5 commits into from
Oct 15, 2023

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Oct 14, 2023

Overview

I added eslint rule import/no-duplicates with vscode .setting you mentioned before and consistent-type-imports

PR Checklist

  • I have written documents and tests, if needed.

@manudeli manudeli self-assigned this Oct 14, 2023
@changeset-bot
Copy link

changeset-bot bot commented Oct 14, 2023

🦋 Changeset detected

Latest commit: 803650e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@suspensive/react-query Patch
@suspensive/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@vercel
Copy link

vercel bot commented Oct 14, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
docs ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 9:19pm
visualization ✅ Ready (Inspect) Visit Preview 💬 Add feedback Oct 15, 2023 9:19pm

@vercel vercel bot temporarily deployed to Preview – visualization October 14, 2023 14:49 Inactive
@codecov
Copy link

codecov bot commented Oct 14, 2023

Codecov Report

Merging #219 (803650e) into main (ac33b3a) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #219   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           21        21           
  Lines          835       829    -6     
  Branches       146       146           
=========================================
- Hits           835       829    -6     
Components Coverage Δ
@suspensive/react 100.00% <100.00%> (ø)
@suspensive/react-query ∅ <ø> (∅)

@manudeli manudeli marked this pull request as ready for review October 14, 2023 14:58
@manudeli manudeli requested a review from okinawaa as a code owner October 14, 2023 14:58
@manudeli manudeli requested a review from minsoo-web October 14, 2023 16:05
Copy link
Member

@minsoo-web minsoo-web left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍👍👍!

But, why don't you add vscode setting for

"editor.codeActionsOnSave": {
    "source.fixAll.eslint": true
  },

It is So Cool

I will show demo

Oct-15-2023 22-41-37

@manudeli
Copy link
Member Author

manudeli commented Oct 15, 2023

LGTM 👍👍👍!

But, why don't you add vscode setting for

"editor.codeActionsOnSave": {
    "source.fixAll.eslint": true
  },

It is So Cool

I will show demo

Oct-15-2023 22-41-37 Oct-15-2023 22-41-37

I don't know why I could get fixing by eslint, but my code was fixed by eslint without editor.codeActionsOnSave.source.fixAll.eslint too.

but anyway, You couldn't get fixing by eslint right away in current setting, and if also same for other people, I think it's better to apply setting you mentioned. thanks! I added you as co-author in ce25880

@vercel vercel bot temporarily deployed to Preview – visualization October 15, 2023 21:17 Inactive
@vercel vercel bot temporarily deployed to Preview – docs October 15, 2023 21:19 Inactive
@manudeli
Copy link
Member Author

I update all source as our new eslint rule in 0cf62c1

@manudeli manudeli merged commit 62c3384 into main Oct 15, 2023
13 checks passed
@manudeli manudeli deleted the eslint/chore/no-duplicates-consistent-type-imports branch October 15, 2023 21:22
manudeli added a commit that referenced this pull request Aug 3, 2024
* chore(eslint): add no-duplicates, consistent-type-imports

* chore(.vscode): add editor.codeActionsOnSave.source.fixAll.eslint: true

Co-authored-by: minsoo kim <[email protected]>

* chore(eslint): update to all error

* chore: update all source as eslint rule

* Create good-ads-wait.md

---------

Co-authored-by: minsoo kim <[email protected]>
manudeli added a commit that referenced this pull request Aug 3, 2024
* chore(eslint): add no-duplicates, consistent-type-imports

* chore(.vscode): add editor.codeActionsOnSave.source.fixAll.eslint: true


* chore(eslint): update to all error

* chore: update all source as eslint rule

* Create good-ads-wait.md

---------
manudeli added a commit that referenced this pull request Aug 3, 2024
* chore(eslint): add no-duplicates, consistent-type-imports

* chore(.vscode): add editor.codeActionsOnSave.source.fixAll.eslint: true

Co-authored-by: minsoo kim <[email protected]>

* chore(eslint): update to all error

* chore: update all source as eslint rule

* Create good-ads-wait.md

---------

Co-authored-by: minsoo kim <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants