-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(eslint): add no-duplicates, consistent-type-imports #219
chore(eslint): add no-duplicates, consistent-type-imports #219
Conversation
🦋 Changeset detectedLatest commit: 803650e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Codecov Report
@@ Coverage Diff @@
## main #219 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 21 21
Lines 835 829 -6
Branches 146 146
=========================================
- Hits 835 829 -6
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't know why I could get fixing by eslint, but my code was fixed by eslint without but anyway, You couldn't get fixing by eslint right away in current setting, and if also same for other people, I think it's better to apply setting you mentioned. thanks! I added you as co-author in ce25880 |
I update all source as our new eslint rule in 0cf62c1 |
* chore(eslint): add no-duplicates, consistent-type-imports * chore(.vscode): add editor.codeActionsOnSave.source.fixAll.eslint: true Co-authored-by: minsoo kim <[email protected]> * chore(eslint): update to all error * chore: update all source as eslint rule * Create good-ads-wait.md --------- Co-authored-by: minsoo kim <[email protected]>
* chore(eslint): add no-duplicates, consistent-type-imports * chore(.vscode): add editor.codeActionsOnSave.source.fixAll.eslint: true * chore(eslint): update to all error * chore: update all source as eslint rule * Create good-ads-wait.md ---------
* chore(eslint): add no-duplicates, consistent-type-imports * chore(.vscode): add editor.codeActionsOnSave.source.fixAll.eslint: true Co-authored-by: minsoo kim <[email protected]> * chore(eslint): update to all error * chore: update all source as eslint rule * Create good-ads-wait.md --------- Co-authored-by: minsoo kim <[email protected]>
Overview
I added eslint rule
import/no-duplicates
with vscode .setting you mentioned before andconsistent-type-imports
PR Checklist