Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(*): support react 19 #1389

Merged
merged 8 commits into from
Dec 13, 2024
Merged

feat(*): support react 19 #1389

merged 8 commits into from
Dec 13, 2024

Conversation

manudeli
Copy link
Member

@manudeli manudeli commented Dec 11, 2024

close #929

Overview

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 3:57pm
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 3:57pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 3:57pm

Copy link

coauthors bot commented Dec 11, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli #1389 (comment) #1389 (comment) #1389 (comment) #1389 (review) #1389 5 Co-authored-by: manudeli <[email protected]>
@gwansikk #1389 (comment) #1389 (review) 2 Co-authored-by: gwansikk <[email protected]>
@codecov-commenter #1389 (comment) 1 Co-authored-by: codecov-commenter <[email protected]>

Copy link

changeset-bot bot commented Dec 11, 2024

🦋 Changeset detected

Latest commit: 13856fe

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 7 packages
Name Type
@suspensive/jotai Patch
@suspensive/react-dom Patch
@suspensive/react-native Patch
@suspensive/react-query-4 Patch
@suspensive/react-query-5 Patch
@suspensive/react-query Patch
@suspensive/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

github-actions bot commented Dec 11, 2024

Size Change: -6 B (-0.01%)

Total Size: 69 kB

Filename Size Change
packages/react-dom/dist/FadeIn.cjs 2.13 kB -2 B (-0.09%)
packages/react-dom/dist/index.cjs 2.36 kB -2 B (-0.08%)
packages/react-dom/dist/InView.cjs 2.1 kB -1 B (-0.05%)
packages/react-dom/dist/useFadeIn.cjs 2.04 kB -1 B (-0.05%)
packages/react-dom/dist/useInView.cjs 1.87 kB -1 B (-0.05%)
packages/react-query-4/dist/QueryClientConsumer.js 140 B +1 B (+0.72%)
ℹ️ View Unchanged
Filename Size
packages/jotai/dist/Atom.cjs 660 B
packages/jotai/dist/Atom.js 115 B
packages/jotai/dist/AtomValue.cjs 647 B
packages/jotai/dist/AtomValue.js 120 B
packages/jotai/dist/index.cjs 755 B
packages/jotai/dist/index.js 158 B
packages/jotai/dist/SetAtom.cjs 645 B
packages/jotai/dist/SetAtom.js 118 B
packages/react-dom/dist/FadeIn.js 140 B
packages/react-dom/dist/index.js 177 B
packages/react-dom/dist/InView.js 130 B
packages/react-dom/dist/useFadeIn.js 133 B
packages/react-dom/dist/useInView.js 120 B
packages/react-native/dist/index.cjs 619 B
packages/react-native/dist/index.js 122 B
packages/react-native/dist/TestText.cjs 612 B
packages/react-native/dist/TestText.js 119 B
packages/react-query-4/dist/index.cjs 1.86 kB
packages/react-query-4/dist/index.js 394 B
packages/react-query-4/dist/infiniteQueryOptions.cjs 548 B
packages/react-query-4/dist/infiniteQueryOptions.js 144 B
packages/react-query-4/dist/Mutation.cjs 821 B
packages/react-query-4/dist/Mutation.js 132 B
packages/react-query-4/dist/PrefetchInfiniteQuery.cjs 722 B
packages/react-query-4/dist/PrefetchInfiniteQuery.js 155 B
packages/react-query-4/dist/PrefetchQuery.cjs 712 B
packages/react-query-4/dist/PrefetchQuery.js 147 B
packages/react-query-4/dist/QueryClientConsumer.cjs 665 B
packages/react-query-4/dist/QueryErrorBoundary.cjs 1.12 kB
packages/react-query-4/dist/QueryErrorBoundary.js 142 B
packages/react-query-4/dist/queryOptions.cjs 540 B
packages/react-query-4/dist/queryOptions.js 135 B
packages/react-query-4/dist/SuspenseInfiniteQuery.cjs 1.05 kB
packages/react-query-4/dist/SuspenseInfiniteQuery.js 155 B
packages/react-query-4/dist/SuspenseQueries.cjs 923 B
packages/react-query-4/dist/SuspenseQueries.js 149 B
packages/react-query-4/dist/SuspenseQuery.cjs 1.04 kB
packages/react-query-4/dist/SuspenseQuery.js 147 B
packages/react-query-4/dist/usePrefetchInfiniteQuery.cjs 648 B
packages/react-query-4/dist/usePrefetchInfiniteQuery.js 148 B
packages/react-query-4/dist/usePrefetchQuery.cjs 639 B
packages/react-query-4/dist/usePrefetchQuery.js 140 B
packages/react-query-4/dist/useSuspenseInfiniteQuery.cjs 833 B
packages/react-query-4/dist/useSuspenseInfiniteQuery.js 148 B
packages/react-query-4/dist/useSuspenseQueries.cjs 833 B
packages/react-query-4/dist/useSuspenseQueries.js 142 B
packages/react-query-4/dist/useSuspenseQuery.cjs 824 B
packages/react-query-4/dist/useSuspenseQuery.js 140 B
packages/react-query-5/dist/index.cjs 1.76 kB
packages/react-query-5/dist/index.js 391 B
packages/react-query-5/dist/infiniteQueryOptions.cjs 573 B
packages/react-query-5/dist/infiniteQueryOptions.js 144 B
packages/react-query-5/dist/Mutation.cjs 821 B
packages/react-query-5/dist/Mutation.js 132 B
packages/react-query-5/dist/PrefetchInfiniteQuery.cjs 647 B
packages/react-query-5/dist/PrefetchInfiniteQuery.js 145 B
packages/react-query-5/dist/PrefetchQuery.cjs 639 B
packages/react-query-5/dist/PrefetchQuery.js 137 B
packages/react-query-5/dist/QueryClientConsumer.cjs 663 B
packages/react-query-5/dist/QueryClientConsumer.js 140 B
packages/react-query-5/dist/QueryErrorBoundary.cjs 1.12 kB
packages/react-query-5/dist/QueryErrorBoundary.js 142 B
packages/react-query-5/dist/queryOptions.cjs 563 B
packages/react-query-5/dist/queryOptions.js 136 B
packages/react-query-5/dist/SuspenseInfiniteQuery.cjs 833 B
packages/react-query-5/dist/SuspenseInfiniteQuery.js 145 B
packages/react-query-5/dist/SuspenseQueries.cjs 671 B
packages/react-query-5/dist/SuspenseQueries.js 139 B
packages/react-query-5/dist/SuspenseQuery.cjs 825 B
packages/react-query-5/dist/SuspenseQuery.js 137 B
packages/react-query-5/dist/usePrefetchInfiniteQuery.cjs 577 B
packages/react-query-5/dist/usePrefetchInfiniteQuery.js 148 B
packages/react-query-5/dist/usePrefetchQuery.cjs 569 B
packages/react-query-5/dist/usePrefetchQuery.js 140 B
packages/react-query-5/dist/useSuspenseInfiniteQuery.cjs 577 B
packages/react-query-5/dist/useSuspenseInfiniteQuery.js 148 B
packages/react-query-5/dist/useSuspenseQueries.cjs 571 B
packages/react-query-5/dist/useSuspenseQueries.js 142 B
packages/react-query-5/dist/useSuspenseQuery.cjs 569 B
packages/react-query-5/dist/useSuspenseQuery.js 140 B
packages/react-query/dist/index.cjs 551 B
packages/react-query/dist/index.js 121 B
packages/react-query/dist/v4.cjs 550 B
packages/react-query/dist/v4.js 116 B
packages/react-query/dist/v5.cjs 550 B
packages/react-query/dist/v5.js 116 B
packages/react/dist/ClientOnly.cjs 734 B
packages/react/dist/ClientOnly.js 141 B
packages/react/dist/DefaultProps.cjs 1.05 kB
packages/react/dist/DefaultProps.js 167 B
packages/react/dist/Delay.cjs 1.23 kB
packages/react/dist/Delay.js 159 B
packages/react/dist/DevMode.cjs 530 B
packages/react/dist/DevMode.js 131 B
packages/react/dist/ErrorBoundary.cjs 2.74 kB
packages/react/dist/ErrorBoundary.js 205 B
packages/react/dist/ErrorBoundaryGroup.cjs 1.38 kB
packages/react/dist/ErrorBoundaryGroup.js 195 B
packages/react/dist/index.cjs 4.32 kB
packages/react/dist/index.js 368 B
packages/react/dist/Suspense.cjs 1.29 kB
packages/react/dist/Suspense.js 171 B
packages/react/dist/Suspensive.cjs 1.26 kB
packages/react/dist/Suspensive.js 175 B
packages/react/dist/wrap.cjs 3.78 kB
packages/react/dist/wrap.js 209 B

compressed-size-action

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 73.93%. Comparing base (9127cec) to head (13856fe).

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1389      +/-   ##
==========================================
- Coverage   75.63%   73.93%   -1.70%     
==========================================
  Files          70       70              
  Lines         591      587       -4     
  Branches      129      129              
==========================================
- Hits          447      434      -13     
- Misses        132      141       +9     
  Partials       12       12              
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 95.55% <100.00%> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 83.47% <100.00%> (-7.73%) ⬇️
@suspensive/react-query-4 0.00% <0.00%> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/codemods 41.97% <ø> (ø)

@@ -19,7 +19,7 @@ describe('cli', () => {
expect(result).toContain('Usage: @suspensive/react-query [options] [command]')
})

it('should display the status of the packages', () => {
it.todo('should display the status of the packages', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gwansikk Could you remove todo after resolving error please?

@@ -61,7 +61,7 @@ describe('package', () => {
})

describe('getTargetSuspensiveReactQueryAPIs', () => {
it('should get the target @suspensive/react-query version 4 APIs', () => {
it.todo('should get the target @suspensive/react-query version 4 APIs', () => {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gwansikk Could you remove todo after resolving error please?

packages/react-query/src/bin/utils/package.ts Show resolved Hide resolved
Copy link
Collaborator

@gwansikk gwansikk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

packages/react-query/src/bin/utils/package.ts Show resolved Hide resolved
@manudeli manudeli merged commit d381f94 into main Dec 13, 2024
16 checks passed
@manudeli manudeli deleted the feat/react-19 branch December 13, 2024 09:55
manudeli added a commit that referenced this pull request Dec 13, 2024
This PR was opened by the [Changesets
release](https://github.com/changesets/action) GitHub action. When
you're ready to do a release, you can merge this and the packages will
be published to npm automatically. If you're not ready to do a release
yet, that's fine, whenever you add more changesets to main, this PR will
be updated.


# Releases
## @suspensive/[email protected]

### Patch Changes

- [#1389](#1389)
[`d381f94`](d381f94)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): support
react 19

## @suspensive/[email protected]

### Patch Changes

- [#1389](#1389)
[`d381f94`](d381f94)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): support
react 19

## @suspensive/[email protected]

### Patch Changes

- [#1389](#1389)
[`d381f94`](d381f94)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): support
react 19

## @suspensive/[email protected]

### Patch Changes

- [#1389](#1389)
[`d381f94`](d381f94)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): support
react 19

## @suspensive/[email protected]

### Patch Changes

- [#1389](#1389)
[`d381f94`](d381f94)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): support
react 19

- Updated dependencies
\[[`d381f94`](d381f94)]:
    -   @suspensive/[email protected]
    -   @suspensive/[email protected]
    -   @suspensive/[email protected]

## @suspensive/[email protected]

### Patch Changes

- [#1389](#1389)
[`d381f94`](d381f94)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): support
react 19

- Updated dependencies
\[[`d381f94`](d381f94)]:
    -   @suspensive/[email protected]

## @suspensive/[email protected]

### Patch Changes

- [#1389](#1389)
[`d381f94`](d381f94)
Thanks [@manudeli](https://github.com/manudeli)! - feat(\*): support
react 19

- Updated dependencies
\[[`d381f94`](d381f94)]:
    -   @suspensive/[email protected]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Support React 19
3 participants