Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-dom): add
<FadeIn/>
#1362feat(react-dom): add
<FadeIn/>
#1362Changes from 1 commit
d4d6c66
a743248
145e048
1e1238f
c581697
af99fd1
d288710
d9f598e
450a3f9
324f428
5d12190
0ae4863
7b55958
15f62f7
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am concerned about whether setting the default value of delay to 200ms is a good idea. The referenced KakaoPay article derived 200ms based on examples from KakaoPay monitoring, but I’m not sure if this metric is applicable to us or our users.
Since general users are likely to stick with the default values, how about setting it based on popular and well-founded conventions?
ref: https://www.nngroup.com/articles/progress-indicators/
@manudeli @kangju2000
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree your opinion. Do we need to make context provider to set up default prop of FadeIn?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, having a provider could help define the scope and manage it consistently!
This was simply a suggestion to set a default
delay
value.According to an article by the "UX Research Group Nielsen Norman," animations under one second can be distracting and negatively impact the user experience. Providing a best-practice default value would seem like a good approach.