Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(react-native-playground): remove shamefully-hoist and expo 52 version upgrade #1356

Merged
merged 2 commits into from
Nov 14, 2024

Conversation

XionWCFM
Copy link
Contributor

Overview

With the addition of support for pnpm monorepo in expo 52, you can now disable "shamefully hoist" and "node-linker=hoisted".

expo sdk 52 release

Accordingly, we upgrade the existing react-native-playground's expo version to 52 and remove "public-hoist-pattern[]=*".

As a result of testing, if you use the monorepo pattern without hoisting, it works fine locally, but causes problems in EAS remote builds.

However, Playground is not expected to require EAS remote build.

I guess the benefits of not using the hoisting pattern are greater.

Test

I confirmed that the IOS Simulator operates locally and that the entire build process operates.

Trouble Shooting

During the migration process, I often failed to start the expo app due to the cache of metro or packagemanager.

Most problems are caused by mismatched ReactNative versions.

If you are having this problem try

pnpm store prune
pnpm i

pnpm store prune docs

PR Checklist

  • I did below actions if need
  1. I read the Contributing Guide
  2. I added documents and tests.

@XionWCFM XionWCFM requested a review from manudeli as a code owner November 14, 2024 09:59
Copy link

changeset-bot bot commented Nov 14, 2024

⚠️ No Changeset found

Latest commit: e625404

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coauthors bot commented Nov 14, 2024

People can be co-author:

Candidate Reasons Count Add this as commit message
@manudeli #1356 (comment) #1356 (review) #1356 (review) 3 Co-authored-by: manudeli <[email protected]>
@XionWCFM #1356 1 Co-authored-by: XionWCFM <[email protected]>
@codecov-commenter #1356 (comment) 1 Co-authored-by: codecov-commenter <[email protected]>

Copy link

vercel bot commented Nov 14, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
suspensive.org ❌ Failed (Inspect) Nov 14, 2024 5:10pm
v1.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 5:10pm
visualization.suspensive.org ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 14, 2024 5:10pm

Copy link

vercel bot commented Nov 14, 2024

@XionWCFM is attempting to deploy a commit to the Toss Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

codspeed-hq bot commented Nov 14, 2024

CodSpeed Performance Report

Merging #1356 will create unknown performance changes

Comparing XionWCFM:expoversion (e625404) with main (e7e80b1)

Summary

⚠️ No benchmarks were detected in both the base of the PR and the PR.

@codecov-commenter
Copy link

codecov-commenter commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.86%. Comparing base (e7e80b1) to head (e625404).

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main    #1356   +/-   ##
=======================================
  Coverage   71.86%   71.86%           
=======================================
  Files          67       67           
  Lines         583      583           
  Branches      129      129           
=======================================
  Hits          419      419           
  Misses        151      151           
  Partials       13       13           
Components Coverage Δ
@suspensive/react 100.00% <ø> (ø)
@suspensive/react-dom 100.00% <ø> (ø)
@suspensive/react-native 100.00% <ø> (ø)
@suspensive/react-query 72.86% <ø> (ø)
@suspensive/react-query-4 0.00% <ø> (ø)
@suspensive/react-query-5 0.00% <ø> (ø)
@suspensive/jotai 0.00% <ø> (ø)
@suspensive/codemods 41.97% <ø> (ø)

.npmrc Outdated Show resolved Hide resolved
Copy link
Member

@manudeli manudeli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So cool❤️ Thanks! Best environment to develop @suspensive/react-native

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants