-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(react-native-playground): remove shamefully-hoist and expo 52 version upgrade #1356
Conversation
|
People can be co-author:
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@XionWCFM is attempting to deploy a commit to the Toss Team on Vercel. A member of the Team first needs to authorize it. |
CodSpeed Performance ReportMerging #1356 will create unknown performance changesComparing Summary
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1356 +/- ##
=======================================
Coverage 71.86% 71.86%
=======================================
Files 67 67
Lines 583 583
Branches 129 129
=======================================
Hits 419 419
Misses 151 151
Partials 13 13
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So cool❤️ Thanks! Best environment to develop @suspensive/react-native
Overview
With the addition of support for pnpm monorepo in expo 52, you can now disable "shamefully hoist" and "node-linker=hoisted".
expo sdk 52 release
Accordingly, we upgrade the existing react-native-playground's expo version to 52 and remove "public-hoist-pattern[]=*".
As a result of testing, if you use the monorepo pattern without hoisting, it works fine locally, but causes problems in EAS remote builds.
However, Playground is not expected to require EAS remote build.
I guess the benefits of not using the hoisting pattern are greater.
Test
I confirmed that the IOS Simulator operates locally and that the entire build process operates.
Trouble Shooting
During the migration process, I often failed to start the expo app due to the cache of metro or packagemanager.
Most problems are caused by mismatched ReactNative versions.
If you are having this problem try
pnpm store prune docs
PR Checklist