Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] ms package as root devDependency to test time #267

Closed
manudeli opened this issue Oct 27, 2023 · 0 comments · Fixed by #274
Closed

[Feature] ms package as root devDependency to test time #267

manudeli opened this issue Oct 27, 2023 · 0 comments · Fixed by #274

Comments

@manudeli
Copy link
Member

manudeli commented Oct 27, 2023 •
edited by minsoo-web
Loading

I mean to use it for test-utils, It is internal package not for user.
If not, I agree with you.

Originally posted by @minsoo-web in #264 (comment)
@manudeli manudeli mentioned this issue Oct 29, 2023
Merged
1 task
manudeli added a commit that referenced this issue Oct 29, 2023
@manudeli
chore(ms): add dev dependency (#274)
15a5531 
fix #267 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

@minsoo-web suggest us to add `ms` in
#264 (comment)
I added `ms` as dev dependency to test apis related with time

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this issue Aug 3, 2024
@manudeli
chore(ms): add dev dependency (#274)
151240f 
fix #267 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

@minsoo-web suggest us to add `ms` in
#264 (comment)
I added `ms` as dev dependency to test apis related with time

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this issue Aug 3, 2024
@manudeli
chore(ms): add dev dependency (#274)
23f8caa 
fix #267 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

@minsoo-web suggest us to add `ms` in
#264 (comment)
I added `ms` as dev dependency to test apis related with time

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
manudeli added a commit that referenced this issue Aug 3, 2024
@manudeli
chore(ms): add dev dependency (#274)
3923505 
fix #267 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

@minsoo-web suggest us to add `ms` in
#264 (comment)
I added `ms` as dev dependency to test apis related with time

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

chore(ms): add dev dependency toss/suspensive
1 participant
@manudeli