Merge branch 'main' into react/feat/wrap

toss · Nov 2, 2023 · d1a04f7 · d1a04f7
2 parents 7e1f097 + 933c43e
commit d1a04f7
Show file tree

Hide file tree

Showing 9 changed files with 25 additions and 11 deletions.
diff --git a/configs/test-utils/src/ThrowError.tsx b/configs/test-utils/src/ThrowError.tsx
@@ -1,8 +1,7 @@
 import type { PropsWithChildren } from 'react'
 import { useEffect, useLayoutEffect, useRef, useState } from 'react'
 
-const isClient = typeof window !== 'undefined'
-export const useIsomorphicLayoutEffect = isClient ? useLayoutEffect : useEffect
+export const useIsomorphicLayoutEffect = typeof window !== 'undefined' ? useLayoutEffect : useEffect
 
 export const useTimeout = (fn: () => void, ms: number) => {
   const fnRef = useRef(fn)

diff --git a/package.json b/package.json
@@ -77,5 +77,8 @@
     "typescript": "^5.1.6",
     "vite": "^4.4.9",
     "vitest": "^0.34.6"
+  },
+  "volta": {
+    "node": "18.16.1"
   }
 }
diff --git a/packages/react-query/CHANGELOG.md b/packages/react-query/CHANGELOG.md
@@ -1,5 +1,12 @@
 # @suspensive/react-query
 
+## 1.18.2
+
+### Patch Changes
+
+- Updated dependencies [a06c31f]
+  - @suspensive/react@1.18.2
+
 ## 1.18.1
 
 ### Patch Changes

diff --git a/packages/react-query/package.json b/packages/react-query/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@suspensive/react-query",
-  "version": "1.18.1",
+  "version": "1.18.2",
   "description": "Useful helpers for @tanstack/react-query with suspense",
   "keywords": [
     "suspensive",
@@ -71,7 +71,7 @@
     "tsd": "^0.28.1"
   },
   "peerDependencies": {
-    "@suspensive/react": "workspace:^1.18.1",
+    "@suspensive/react": "workspace:^1.18.2",
     "@tanstack/react-query": "^4",
     "react": "^16.8 || ^17 || ^18"
   },

diff --git a/packages/react/CHANGELOG.md b/packages/react/CHANGELOG.md
@@ -1,5 +1,11 @@
 # @suspensive/react
 
+## 1.18.2
+
+### Patch Changes
+
+- a06c31f: fix(react): remove useless variable assigning in useIsomorphicLayoutEffect
+
 ## 1.18.1
 
 ### Patch Changes

diff --git a/packages/react/package.json b/packages/react/package.json
@@ -1,6 +1,6 @@
 {
   "name": "@suspensive/react",
-  "version": "1.18.1",
+  "version": "1.18.2",
   "description": "Useful interfaces for React Suspense",
   "keywords": [
     "suspensive",

diff --git a/packages/react/src/hooks/useIsomorphicLayoutEffect.ts b/packages/react/src/hooks/useIsomorphicLayoutEffect.ts
@@ -1,3 +1,2 @@
 import { useEffect, useLayoutEffect } from 'react'
-const isClient = typeof window !== 'undefined'
-export const useIsomorphicLayoutEffect = isClient ? useLayoutEffect : useEffect
+export const useIsomorphicLayoutEffect = typeof window !== 'undefined' ? useLayoutEffect : useEffect
diff --git a/pnpm-lock.yaml b/pnpm-lock.yaml
diff --git a/websites/visualization/package.json b/websites/visualization/package.json
@@ -30,9 +30,9 @@
     "@emotion/react": "^11.10.8",
     "@emotion/styled": "^11.10.8",
     "@jsxcss/emotion": "^1.3.9",
-    "@suspensive/react": "workspace:1.18.1",
+    "@suspensive/react": "workspace:1.18.2",
     "@suspensive/react-await": "workspace:0.0.4",
-    "@suspensive/react-query": "workspace:1.18.1",
+    "@suspensive/react-query": "workspace:1.18.2",
     "@tanstack/react-query": "^4.29.5",
     "@tanstack/react-query-devtools": "^4.29.5",
     "@vercel/analytics": "^1.1.1",