fix(react): update BaseErrorBoundary method simply (#154)

* fix(react): update BaseErrorBoundary method simply * Create gentle-laws-reflect.md
toss · Sep 18, 2023 · 482cfc4 · 482cfc4 · vercel · Sep 18, 2023
1 parent d636e85
commit 482cfc4
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 8 deletions.
diff --git a/.changeset/gentle-laws-reflect.md b/.changeset/gentle-laws-reflect.md
@@ -0,0 +1,5 @@
+---
+"@suspensive/react": patch
+---
+
+fix(react): update BaseErrorBoundary method simply
diff --git a/packages/react/src/ErrorBoundary.tsx b/packages/react/src/ErrorBoundary.tsx
@@ -73,20 +73,16 @@ class BaseErrorBoundary extends Component<ErrorBoundaryProps, ErrorBoundaryState
     const { isError } = this.state
     const { resetKeys } = this.props
     if (isError && prevState.isError && hasResetKeysChanged(prevProps.resetKeys, resetKeys)) {
-      this.resetErrorBoundary()
+      this.reset()
     }
   }
 
   componentDidCatch(error: Error, info: ErrorInfo) {
     this.props.onError?.(error, info)
   }
 
-  resetErrorBoundary = () => {
-    this.props.onReset?.()
-    this.reset()
-  }
-
   reset() {
+    this.props.onReset?.()
     awaitClient.clearError()
     this.setState(initialState)
   }
@@ -99,7 +95,7 @@ class BaseErrorBoundary extends Component<ErrorBoundaryProps, ErrorBoundaryState
       if (typeof fallback === 'function') {
         return createElement(fallback, {
           error,
-          reset: this.resetErrorBoundary,
+          reset: this.reset,
         })
       }
       return fallback
@@ -119,7 +115,7 @@ export const ErrorBoundary = forwardRef<{ reset(): void }, ErrorBoundaryProps>((
 
   const ref = useRef<BaseErrorBoundary>(null)
   useImperativeHandle(resetRef, () => ({
-    reset: () => ref.current?.resetErrorBoundary(),
+    reset: () => ref.current?.reset(),
   }))
 
   return <BaseErrorBoundary {...props} resetKeys={resetKeys} ref={ref} />