Skip to content

Commit

Permalink
chore(pnpm): force corepack by preinstall (#262)
Browse files Browse the repository at this point in the history
fix #243 

# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

If we force [corepack, we don't need to notice what version we need to
use for pnpm](https://pnpm.io/installation#using-corepack).
So I use preinstall of package.json and update CONTRIBUTING.md

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
  • Loading branch information
manudeli authored Oct 27, 2023
1 parent de912c4 commit 2e18451
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
3 changes: 2 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,8 @@ In general, things we find useful when reviewing suggestions are:
```shell
git clone [email protected]:suspensive/react.git
```
2. Install relative packages. [We use pnpm v8. Install it please if need](https://pnpm.io/installation)
2. Please use the correct node version. You can use the version declared in [.nvmrc](https://github.com/suspensive/react/blob/main/.nvmrc). We strongly recommend [nvm](https://github.com/nvm-sh/nvm) to control local machine's node version easily. also We recommend [nvm's deeper shell integration](https://github.com/nvm-sh/nvm#deeper-shell-integration) too.
3. Install packages. [We use pnpm v8. Install pnpm with corepack please if you can](https://pnpm.io/installation#using-corepack). We recommend using corepack for pnpm to automatically use the version declared in the packageManager field of package.json.
```shell
pnpm install
```
Expand Down
1 change: 1 addition & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@
"lint:pack": "packlint sort -R",
"lint:pub": "turbo run lint:pub",
"postinstall": "husky install",
"preinstall": "corepack enable",
"prepack": "turbo run prepack",
"test": "turbo run test",
"test:tsd": "turbo run test:tsd",
Expand Down

2 comments on commit 2e18451

@vercel
Copy link

@vercel vercel bot commented on 2e18451 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vercel
Copy link

@vercel vercel bot commented on 2e18451 Oct 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Successfully deployed to the following URLs:

visualization – ./websites/visualization

visualization-git-main-suspensive.vercel.app
visualization-suspensive.vercel.app
visualization.suspensive.org

Please sign in to comment.