Skip to content

Commit

Permalink
ci(sherif): lint for monorepo (#343)
Browse files Browse the repository at this point in the history
# Overview

<!--
    A clear and concise description of what this pr is about.
 -->

[Sherif](https://github.com/QuiiBz/sherif) is a tool designed to detect
issues with workspace config.
- ref: TanStack/query#6354

## PR Checklist

- [x] I did below actions if need

1. I read the [Contributing
Guide](https://github.com/suspensive/react/blob/main/CONTRIBUTING.md)
2. I added documents and tests.
  • Loading branch information
manudeli authored Nov 11, 2023
1 parent 8eccc31 commit 07c0f22
Show file tree
Hide file tree
Showing 4 changed files with 70 additions and 98 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ jobs:
runs-on: ubuntu-latest
strategy:
matrix:
command: ['lint', 'lint:attw', 'lint:pub', 'test', 'test:tsd', 'type:check', 'build']
command: ['lint', 'lint:attw', 'lint:monorepo', 'lint:pub', 'test', 'test:tsd', 'type:check', 'build']
steps:
- uses: actions/checkout@v4
- uses: pnpm/action-setup@v2
Expand Down
2 changes: 2 additions & 0 deletions package.json
Original file line number Diff line number Diff line change
Expand Up @@ -36,6 +36,7 @@
"graph": "rimraf ./graph && mkdir graph && turbo run build --graph=graph/index.html",
"lint": "turbo run prepack lint",
"lint:attw": "turbo run prepack lint:attw",
"lint:monorepo": "sherif",
"lint:pack": "packlint sort -R",
"lint:pub": "turbo run prepack lint:pub",
"postinstall": "husky install",
Expand Down Expand Up @@ -73,6 +74,7 @@
"prettier": "^3.0.3",
"publint": "^0.2.5",
"rimraf": "^5.0.5",
"sherif": "^0.4.2",
"tsup": "^7.2.0",
"turbo": "latest",
"typescript": "^5.2.2",
Expand Down
162 changes: 66 additions & 96 deletions pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion websites/visualization/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,6 @@
"@next/eslint-plugin-next": "14.0.2",
"@types/react": "^18.2.34",
"@types/react-dom": "^18.2.14",
"eslint-config-next": "^14.0.0"
"eslint-config-next": "^14.0.2"
}
}

0 comments on commit 07c0f22

Please sign in to comment.