Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Inline replace secp256k1 #79

Merged
merged 12 commits into from
Feb 1, 2024
Merged

Conversation

metalurgical
Copy link
Collaborator

@metalurgical metalurgical commented Jan 18, 2024

This fixes the incompatibility issues we have been experiencing between secp256k1 implementations for boilertalk and gigabitcoin as well as breaking changes in different minor versions of gigabitcoin.

@metalurgical metalurgical mentioned this pull request Jan 23, 2024
Copy link
Contributor

@ieow ieow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ieow
Copy link
Contributor

ieow commented Jan 23, 2024

@himanshuchawla009 , could you review before we merge to master

Copy link
Member

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, just sapphire tests needs a bit of update in test users

Tests/TorusUtilsTests/SapphireTest.swift Show resolved Hide resolved
Copy link
Member

@himanshuchawla009 himanshuchawla009 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@metalurgical metalurgical merged commit 76c9b17 into master Feb 1, 2024
1 check passed
@metalurgical metalurgical deleted the inline_replace_secp256k1 branch February 1, 2024 03:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants