Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: en not loaded when browser lang is set #442

Merged
merged 1 commit into from
Oct 3, 2023
Merged

fix: en not loaded when browser lang is set #442

merged 1 commit into from
Oct 3, 2023

Conversation

lionellbriones
Copy link
Contributor

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Screenshot 2023-10-03 at 12 33 20 PM

Issue Number: N/A

What is the new behavior?

Screenshot 2023-10-03 at 12 18 42 PM

Other information

chaitanyapotti
chaitanyapotti approved these changes Oct 3, 2023
View reviewed changes
Copy link
Member

@chaitanyapotti chaitanyapotti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chaitanyapotti chaitanyapotti merged commit 6a9d20c into develop Oct 3, 2023
1 check passed
@chaitanyapotti chaitanyapotti deleted the fix/en-not-loaded branch October 3, 2023 04:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chaitanyapotti chaitanyapotti chaitanyapotti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lionellbriones @chaitanyapotti