Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logout sync #329

Draft
wants to merge 4 commits into
base: develop
Choose a base branch
from
Draft

Logout sync #329

wants to merge 4 commits into from

Conversation

jiafuei
Copy link
Contributor

@jiafuei jiafuei commented Jun 29, 2022

Pull request type

Please check the type of change your PR introduces:

  • Bugfix
  • Feature
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Documentation content changes
  • Other (please describe):

What is the current behavior?

Issue Number: N/A

What is the new behavior?

  • Sync logout across tabs ( Main wallet only )

Other information

@jiafuei jiafuei marked this pull request as ready for review June 30, 2022 06:41
@jiafuei jiafuei marked this pull request as draft June 30, 2022 12:14
@jiafuei jiafuei force-pushed the feat/sync-logout branch 2 times, most recently from 45fc8ae to 5dc0d8a Compare July 4, 2022 01:57
@jiafuei jiafuei force-pushed the feat/sync-logout branch 2 times, most recently from 6f861ff to edb5d33 Compare July 12, 2022 12:29
@ieow ieow mentioned this pull request Jul 13, 2022
Closed
7 tasks
@jiafuei jiafuei force-pushed the feat/sync-logout branch from 65a1e47 to 00cd5bf Compare July 13, 2022 16:28
@jiafuei
Copy link
Contributor Author

jiafuei commented Jul 15, 2022 •
edited
Loading

Current state of this PR:

  • Logout sync is working for wallet (non embed), UI will redirect to /login
  • For embed, wallet logs out but dapp UI does not reflect the logged out state (magiceden, holaplex, laddercaster)

@jiafuei jiafuei force-pushed the feat/sync-logout branch from 00cd5bf to 6516e41 Compare July 18, 2022 01:25
jiafuei added 4 commits July 19, 2022 10:34
@jiafuei
feat: sync logout across browser tab sessions
624b3ed 
feat: constrain to origin, ignore repeated logout messages from current window

feat: temp fix for brave browser instant logout

feat: skip broadcast if logout was received from bc

feat: use native methods for bc instead of server

feat: scope channel name using verifierid and browser
@jiafuei
feat: use timeout & cleanup
4d79e9d
@jiafuei
chore: use latest broadcast-channel package for timeout
06eef30
@jiafuei
feat: logout sync for embed
8c35ca7 
feat: logout for embed
@jiafuei jiafuei force-pushed the feat/sync-logout branch from 6516e41 to 8c35ca7 Compare July 19, 2022 07:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@jiafuei