Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Withdraw the Arch Linux image (renamed) #82

Merged
merged 1 commit into from
Jan 25, 2024
Merged

Withdraw the Arch Linux image (renamed) #82

merged 1 commit into from
Jan 25, 2024

Conversation

debarshiray
Copy link
Contributor

@debarshiray debarshiray commented Jun 6, 2023 •
edited
Loading

Toolbx now offers built-in support for Arch Linux and these images are
maintained as part of the Toolbx project.

@debarshiray
Copy link
Contributor Author

This was discussed in containers/toolbox#861 (comment)

@debarshiray debarshiray mentioned this pull request Jun 6, 2023
Merged
Foxboron
Foxboron previously approved these changes Jun 6, 2023
View reviewed changes
@debarshiray
Copy link
Contributor Author

Thanks for the review, @Foxboron !

debarshiray added a commit to debarshiray/toolbx-images that referenced this pull request Jun 6, 2023
@debarshiray
archlinux: Rename to arch
3ec3400 
The os-release(5) ID on Arch Linux is 'arch', not 'archlinux'.  The
convention of naming the Toolbx images according to the os-release(5) ID
is deeply ingrained in the Toolbx code base.  It will be better to keep
things simple by continuing that practice, instead of adding a one-off
exception.  Especially, now that built-in support for Arch Linux will be
added to Toolbx.

toolbx-images#82
@debarshiray debarshiray force-pushed the wip/rishi/rename-archlinux-to-arch branch from 0093a30 to 3ec3400 Compare June 6, 2023 22:15
@debarshiray
Copy link
Contributor Author

Added a link to this pull request in the commit message.

@travier
Copy link
Member

travier commented Jun 7, 2023

Given that the images are going to be made available soon "officially" in the toolbx namespace on quay, I think we should not touch those and simply remove them once ready.

@debarshiray
Copy link
Contributor Author

Given that the images are going to be made available soon "officially" in the toolbx namespace on quay, I think we should not touch those and simply remove them once ready.

Yes, that's fine with me too. What's left to be done for that? eg., containers/toolbox#483

The situation with the Arch Linux images is more pressing than Ubuntu, because there's only one image, and if it's not available with the right name, then we can't wire it up to --distro.

debarshiray added a commit to debarshiray/toolbx-images that referenced this pull request Jan 16, 2024
@debarshiray
Withdraw the Arch Linux images
293d6f0 
Toolbx now offers built-in support for Arch Linux and these images are
maintained as part of the Toolbx project.

toolbx-images#82
@debarshiray debarshiray force-pushed the wip/rishi/rename-archlinux-to-arch branch from 3ec3400 to 293d6f0 Compare January 16, 2024 17:30
@debarshiray
Copy link
Contributor Author

Given that the images are going to be made available soon "officially" in the toolbx namespace on quay, I think we should not touch those and simply remove them once ready.

We now have a new Toolbx release that offers built-in support for Arch Linux and it's slowly making it's way to various distributions. So, I took your suggestion and updated this pull request to remove the Arch Linux images.

debarshiray added a commit to debarshiray/toolbx-images that referenced this pull request Jan 16, 2024
@debarshiray
Withdraw the Arch Linux images
ebd1a90 
Toolbx now offers built-in support for Arch Linux and these images are
maintained as part of the Toolbx project.

toolbx-images#82
@debarshiray debarshiray force-pushed the wip/rishi/rename-archlinux-to-arch branch from 293d6f0 to ebd1a90 Compare January 16, 2024 17:36
@debarshiray debarshiray changed the title archlinux: Rename to arch Withdraw the Arch Linux image Jan 16, 2024
@debarshiray debarshiray changed the title Withdraw the Arch Linux image Withdraw the Arch Linux image (renamed) Jan 16, 2024
debarshiray added a commit to debarshiray/toolbx-images that referenced this pull request Jan 16, 2024
@debarshiray
Withdraw the Arch Linux images
6fc3a51 
Toolbx now offers built-in support for Arch Linux and these images are
maintained as part of the Toolbx project.

toolbx-images#82
@debarshiray debarshiray force-pushed the wip/rishi/rename-archlinux-to-arch branch from ebd1a90 to 6fc3a51 Compare January 16, 2024 23:27
travier
travier reviewed Jan 18, 2024
View reviewed changes
Copy link
Member

@travier travier left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I'll wait a few weeks to let the new toolbox land in distros and then we can merge this.

Foxboron
Foxboron previously approved these changes Jan 18, 2024
View reviewed changes
This was referenced Jan 18, 2024
Closed
Closed
Closed
@debarshiray
Copy link
Contributor Author

LGTM. I'll wait a few weeks to let the new toolbox land in distros and then we can merge this.

Cool.

debarshiray added a commit to debarshiray/toolbx-images that referenced this pull request Jan 19, 2024
@debarshiray
Withdraw the Arch Linux images
34f0693 
Toolbx now offers built-in support for Arch Linux and these images are
maintained as part of the Toolbx project.

toolbx-images#82
@debarshiray debarshiray force-pushed the wip/rishi/rename-archlinux-to-arch branch from 6fc3a51 to 34f0693 Compare January 19, 2024 20:50
@travier travier mentioned this pull request Jan 22, 2024
Closed
@travier
Copy link
Member

travier commented Jan 22, 2024

The README here still needs an update to match #84 (comment)

@debarshiray
Withdraw the Arch Linux images
d63a974 
Toolbx now offers built-in support for Arch Linux and these images are
maintained as part of the Toolbx project.

toolbx-images#82
@debarshiray debarshiray force-pushed the wip/rishi/rename-archlinux-to-arch branch from 34f0693 to d63a974 Compare January 24, 2024 21:22
@debarshiray
Copy link
Contributor Author

The README here still needs an update to match #84 (comment)

Done.

@travier travier merged commit bd56693 into toolbx-images:main Jan 25, 2024
@travier
Copy link
Member

travier commented Jan 25, 2024

Thanks!

@debarshiray debarshiray deleted the wip/rishi/rename-archlinux-to-arch branch January 25, 2024 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@travier travier travier approved these changes

@Foxboron Foxboron Foxboron left review comments

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@debarshiray @travier @Foxboron