Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

(WIP) MFT batch transfers #1

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

(WIP) MFT batch transfers #1

wants to merge 5 commits into from

Conversation

jriemann
Copy link

Done:

  • Regular (i.e. no approvals) batch transfers working.

In progress:

  • batch_transfer_on_call (requires a bit more refactoring) & related tests
  • Approval logic for batch methods.
  • More unit tests

@jriemann jriemann requested a review from sb- March 22, 2022 07:32
sb-
sb- reviewed Mar 24, 2022
View reviewed changes
examples/multi-token/test-contract-defi/src/lib.rs
Comment on lines +32 to +35
trait ValueReturnTrait {
fn value_please(&self, num_tokens: usize, amount_to_return: String) -> PromiseOrValue<Vec<U128>>;
}

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does this need to be repeated?

examples/multi-token/test-contract-defi/Cargo.toml
[package]
name = "defi"
version = "0.0.1"
authors = ["Near Inc <[email protected]>"]
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: replace with your info throughout

examples/multi-token/build.sh
cd "`dirname $0`"

cargo build --all --target wasm32-unknown-unknown --release
cp $TARGET/wasm32-unknown-unknown/release/defi.wasm ./res/
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cp $TARGET/wasm32-unknown-unknown/release/*.wasm ./res?

examples/multi-token/Cargo.toml
nep-246 = { path = "../../" }
[dev-dependencies]
anyhow = "1.0"
near-primitives = "0.5.0"
near-sdk = "4.0.0-pre.6"
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bump this latest

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sb- sb- sb- left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jriemann @sb-