Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix clippy 1.83 warnings (elide lifetimes, use non_exhaustive) #326

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix clippy 1.83 warnings (elide lifetimes, use non_exhaustive) #326

wants to merge 1 commit into from
+7 −13

Conversation

strohel
Copy link
Member

@strohel strohel commented Dec 5, 2024

No description provided.

@strohel strohel requested review from bschwind and goodhoko December 5, 2024 20:48
@strohel strohel changed the title Fix clippy 1.83 warnings (elite lifetimes, use non_exhaustive) Fix clippy 1.83 warnings (elide lifetimes, use non_exhaustive) Dec 5, 2024
@strohel strohel mentioned this pull request Dec 6, 2024
Open
bschwind
bschwind approved these changes Dec 11, 2024
View reviewed changes
Copy link
Member

@bschwind bschwind left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from the failing tests (pre-existing)

goodhoko
goodhoko approved these changes Dec 12, 2024
View reviewed changes
Copy link
Member

@goodhoko goodhoko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goodhoko goodhoko goodhoko approved these changes

@bschwind bschwind bschwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@strohel @bschwind @goodhoko