Feature/custom translation of scripts #17
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Startouf
commented
Oct 23, 2018
|
|
||
| module Elasticsearch | ||
| module API | ||
| module Response | ||
| class ExplainNode | ||
| include Renderable | ||
| extend Forwardable | ||
| extend ::Forwardable |
There was a problem hiding this comment.
Note in Ruby 2.5 omitting the :: will perform a same folder constant lookup. + we need to require 'forwardable' explicitely. Should be retro-compatible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows to pass a proc lambda that will let you convert hardly-readable painless scripts into a more human friendly format (cf Readme)