Minor fixes in test and readme #77
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielrehmann
force-pushed
the
minor_fixes_in_test_and_readme
branch
from
28a6a91
to
7136f9c
Compare
|
The Build failed with |
magro
reviewed
Mar 28, 2023
| /** | ||
| * Copyright 2022 Tomorrow GmbH @ https://tomorrow.one | ||
| /* | ||
| * Copyright 2023 Tomorrow GmbH @ https://tomorrow.one |
There was a problem hiding this comment.
I think this should not be touched, AFAIK the year stands for the year when this file got publicly released.
It also breaks the licenseTest task, see the failed build... To relax the license plugin for new files in the future can probably be kept out of this here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The readme still refers to the main branch as
masterwhile navigating the tests I found a barrier that did not do anything and removed it