Update settings editor to use sqlite3 #453
Open
+101
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes #451 Add functionality to update config manager state and store settings using sqlite3 in the settings editor. * **Config Manager (`src/biscuit/settings/config.py`):** - Add methods to save and load settings from sqlite3. - Update `__init__` method to initialize sqlite3 database in `datadir`. - Update `load_data` method to load settings from sqlite3. * **Settings Editor (`src/biscuit/settings/editor/editor.py`):** - Add methods to save and load settings from sqlite3. - Update `add_sections` method to load settings from config manager. * **Settings (`src/biscuit/settings/settings.py`):** - Update `Settings` class to use sqlite3 for configuration. - Update `late_setup` method to load settings from sqlite3. --- For more details, open the [Copilot Workspace session](https://copilot-workspace.githubnext.com/tomlin7/biscuit/issues/451?shareId=XXXX-XXXX-XXXX-XXXX).
|
Hey i was just going through this PR and noticed that you are using key value in sqlite. Maybe this would be helpful? https://github.com/piskvorky/sqlitedict |
|
@vyshnav-vinod oh that's very cool! thanks for sharing, will check when I get back to this PR <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #451
Add functionality to update config manager state and store settings using sqlite3 in the settings editor.
add_sectionsmethod to load settings from the config manager.Settingsto use sqlite3 for configuration.late_setupmethod to load settings from sqlite3.