Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 2x image generation #40

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

egrossnickle
Copy link

2x images weren't being generated because with the input data being sanitized, the make2x checkbox value evaluates to boolean true, not string 'true'.

@jonasskafte
Copy link

Thank you, thank you, thank you! 👍 👍 👍

@after8
Copy link

after8 commented Jan 8, 2016

I still have the problem with retina2x. Where do I find the working version. The one I just downloaded from https://de.wordpress.org/plugins/manual-image-crop/ ist still not working. Thank you very much for your help

@jonasskafte
Copy link

Hi there after8,

Try this link: https://github.com/tomaszsita/wp-manual-image-crop/archive/master.zip – the one you can download from https://de.wordpress.org/plugins/manual-image-crop/ is the original version of the plugin, which hasn't been merged (yet) with this version (the one that egrossnickle made).

I'm actually not sure if it works, even though I gave my thanks here on this thread, as I had to disable the site that I was working on completely. Anyway, I'm looking at relaunching it soon and so it would be good to know if works well for you, so please keep us updated.

Thanks,

Jonas

@noreabu noreabu mentioned this pull request Apr 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants