Add annotation for tests with miri ignore #6981
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tiif
commented
Nov 19, 2024
There was a problem hiding this comment.
I am pretty surprised that miri can actually run buffer_not_included_in_future here as socket is not yet supported. Is this test using socketpair?
There was a problem hiding this comment.
The buffer_not_included_in_future test is an assertion about the size of a future. It does not run the future.
Darksonn
approved these changes
Nov 19, 2024
Darksonn
added
A-tokio
|
Are you able to resolve the merge conflict? Thanks! |
|
Sure, I also did a miri version bump to get certain flag support for |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I added annotation for all unsupported FFI errors so it'd be easier to open up the test later if miri started to support those syscalls.
cc #6812