Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(3197): Fix sync with Bitbucket #3204

Merged
merged 4 commits into from
Nov 25, 2024
Merged

Conversation

georgebuciuman
Copy link
Contributor

Why does this PR exist?

Closes #3197

What does this pull request do?

Fixes sync with Bitbucket provider:

  • pull when the option is to syng with a single file was not working
  • push was removing all other .json files in the selected folder (either root of the chosen folder)

Testing this change

Sync tokens with Bitbucket. Pull, change, push should work. Both way sync should work.

Additional Notes (if any)

Copy link

changeset-bot bot commented Nov 20, 2024

🦋 Changeset detected

Latest commit: 3fecf8d

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tokens-studio/figma-plugin Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Nov 20, 2024

⤵️ 📦 ✨ The artifact was successfully created! Want to test it? Download it here 👀 🎁

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Commit SHA:6227668718840f72a17de56a241f7d881f37a87f

Test coverage results 🧪

Code coverage diff between base branch:main and head branch: fix-bitbucket-provider 
Status File % Stmts % Branch % Funcs % Lines
🔴 total 66.98 (-0.24) 57.86 (-0.12) 63.84 (-0.11) 67.33 (-0.25)
🔴 packages/tokens-studio-for-figma/src/storage/BitbucketTokenStorage.ts 48.54 (-31.24) 42.1 (-18.68) 56.52 (-16.2) 48 (-31.12)

Copy link
Contributor

github-actions bot commented Nov 20, 2024

Commit SHA:6227668718840f72a17de56a241f7d881f37a87f
Current PR reduces the test coverage percentage by 1 for some tests

@rbosker
Copy link
Collaborator

rbosker commented Nov 22, 2024

Tested both scenario's and these are fixed. Also tested single files in a folder structure.

@georgebuciuman georgebuciuman merged commit 23caccd into main Nov 25, 2024
10 of 11 checks passed
@georgebuciuman georgebuciuman deleted the fix-bitbucket-provider branch November 25, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Push to Bitbucket removes all other .json files in repo
4 participants