Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: use flex center to get rid of modal blur #108

Closed
wants to merge 1 commit into from

Conversation

pengx17
Copy link
Contributor

@pengx17 pengx17 commented Nov 27, 2023

Do not use transform to center the modal. It has know issue to cause modal to have blurred texts.
radix-ui/website#383

Copy link
Member

@CatsJuice CatsJuice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

However, the migration of the current repository is almost complete, and the version of @toeverything/components should not be bumped further in AFFiNE.

@pengx17
Copy link
Contributor Author

pengx17 commented Nov 27, 2023

However, the migration of the current repository is almost complete, and the version of @toeverything/components should not be bumped further in AFFiNE.

If you have fixed this issue on your migrated one, we can close this PR and favor your solution instead.

@pengx17 pengx17 closed this Dec 4, 2023
pengx17 added a commit to toeverything/AFFiNE that referenced this pull request Dec 5, 2023
moved toeverything/design#108

Do not use transform to center the modal. It has know issue to cause modal to have blurred texts.

radix-ui/website#383

fix #5176
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants